Deprecate enable_cloudwatch_metrics from Frameworks

There is a warning message for now, but it will be removed later.

Author: Ignacio Quintero

CHANGELOG.rst

@@ -2,6 +2,10 @@
 CHANGELOG
 =========
 
+1.6.2dev
+========
+* deprecate enable_cloudwatch_metrics from Framework Estimators.
+
 1.6.1
 =====
 

src/sagemaker/estimator.py

@@ -507,8 +507,8 @@ def __init__(self, entry_point, source_dir=None, hyperparameters=None, enable_cl
                 The hyperparameters are made accessible as a dict[str, str] to the training code on SageMaker.
                 For convenience, this accepts other types for keys and values, but ``str()`` will be called
                 to convert them before training.
-            enable_cloudwatch_metrics (bool): Whether training and hosting containers will
-               generate CloudWatch metrics under the AWS/SageMakerContainer namespace (default: False).
+            enable_cloudwatch_metrics (bool): [DEPRECATED] Now there are cloudwatch metrics emitted by all SageMaker
+                training jobs. This will be ignored for now and removed in a further release.
             container_log_level (int): Log level to use within the container (default: logging.INFO).
                 Valid values are defined in the Python logging module.
             code_location (str): Name of the S3 bucket where custom code is uploaded (default: None).
@@ -521,7 +521,9 @@ def __init__(self, entry_point, source_dir=None, hyperparameters=None, enable_cl
         super(Framework, self).__init__(**kwargs)
         self.source_dir = source_dir
         self.entry_point = entry_point
-        self.enable_cloudwatch_metrics = enable_cloudwatch_metrics
+        if enable_cloudwatch_metrics:
+            logging.warn('enable_cloudwatch_metrics is now deprecated and will be removed in the future.')
+        self.enable_cloudwatch_metrics = False
         self.container_log_level = container_log_level
         self._hyperparameters = hyperparameters or {}
         self.code_location = code_location

src/sagemaker/mxnet/README.rst

@@ -543,9 +543,6 @@ The MXNetModel constructor takes the following arguments:
    directory with any other training source code dependencies aside from
    tne entry point file. Structure within this directory will be
    preserved when training on SageMaker.
--  ``enable_cloudwatch_metrics (boolean):`` Optional. If true, training
-   and hosting containers will generate Cloudwatch metrics under the
-   AWS/SageMakerContainer namespace.
 -  ``container_log_level (int):`` Log level to use within the container.
    Valid values are defined in the Python logging module.
 -  ``code_location (str):`` Optional. Name of the S3 bucket where your