Skip to content

Commit 59c736c

Browse files
committed
fix: lock SKLearn framework version to latest for integ test and add assertion for ValueError in numpy deserializer unit test
1 parent 4906998 commit 59c736c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

tests/integ/sagemaker/experiments/test_run.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -693,7 +693,7 @@ def _generate_estimator(
693693
sagemaker_client_config=sagemaker_client_config,
694694
)
695695
return SKLearn(
696-
framework_version="0.23-1",
696+
framework_version="1.2-1",
697697
entry_point=_ENTRY_POINT_PATH,
698698
dependencies=[sdk_tar],
699699
role=execution_role,

tests/unit/sagemaker/deserializers/test_deserializers.py

+3-2
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,9 @@ def test_numpy_deserializer_from_json(numpy_deserializer):
119119
# Sadly, ragged arrays work fine in JSON (giving us a 1D array of Python lists)
120120
def test_numpy_deserializer_from_json_ragged(numpy_deserializer):
121121
stream = io.BytesIO(b"[[1,2,3],\n[4,5,6,7]]")
122-
array = numpy_deserializer.deserialize(stream, "application/json")
123-
assert np.array_equal(array, np.array([[1, 2, 3], [4, 5, 6, 7]]))
122+
with pytest.raises(ValueError) as error:
123+
numpy_deserializer.deserialize(stream, "application/json")
124+
assert "requested array has an inhomogeneous shape" in str(error)
124125

125126

126127
def test_numpy_deserializer_from_json_alpha():

0 commit comments

Comments
 (0)