Skip to content

Commit 4cadce3

Browse files
athewseyVerdi March
and
Verdi March
committed
fix: FrameworkProcessor with ProcessingStep
Update the implementation of FrameworkProcessor to expect _normalize_args() as the point of interface with Pipelines for generating final arguments - not get_run_args(). Add source_dir capability to ProcessingStep for supported processors. Pass through KMS key configs correctly to Estimator. Refactor towards extending the pattern of ScriptProcessor/Processor, rather than trying to decorate/wrap them. Fix the FrameworkProcessor+Pipelines integration test to 1) actually use FWProc and 2) actually check the job is able to succeed. Add a unit test to verify FWProc+Pipelines integration pattern, and expand scope of other unit tests to better exercise FrameworkProcessor while SKLearn is still not aligned to it. Co-authored-by: Verdi March <[email protected]>
1 parent 19884e2 commit 4cadce3

File tree

6 files changed

+403
-201
lines changed

6 files changed

+403
-201
lines changed

src/sagemaker/huggingface/processing.py

+2
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ def _create_estimator(
121121
dependencies=dependencies,
122122
git_config=git_config,
123123
code_location=self.code_location,
124+
output_kms_key=self.output_kms_key,
125+
volume_kms_key=self.volume_kms_key,
124126
enable_network_isolation=False,
125127
image_uri=self.image_uri,
126128
role=self.role,

0 commit comments

Comments
 (0)