change: enable logging-not-lazy pylint check (#909)

Author: knakad

.pylintrc

@@ -84,7 +84,6 @@ disable=
     line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
     len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
     import-error, # TODO: Fix import errors
-    logging-not-lazy, # TODO: Fix logging
     attribute-defined-outside-init, # TODO: Fix scope
     protected-access, # TODO: Fix access
     abstract-method, # TODO: Fix abstract methods

src/sagemaker/analytics.py

@@ -186,14 +186,14 @@ def training_job_summaries(self, force_refresh=False):
         output = []
         next_args = {}
         for count in range(100):
-            logging.debug("Calling list_training_jobs_for_hyper_parameter_tuning_job %d" % count)
+            logging.debug("Calling list_training_jobs_for_hyper_parameter_tuning_job %d", count)
             raw_result = self._sage_client.list_training_jobs_for_hyper_parameter_tuning_job(
                 HyperParameterTuningJobName=self.name, MaxResults=100, **next_args
             )
             new_output = raw_result["TrainingJobSummaries"]
             output.extend(new_output)
             logging.debug(
-                "Got %d more TrainingJobs. Total so far: %d" % (len(new_output), len(output))
+                "Got %d more TrainingJobs. Total so far: %d", len(new_output), len(output)
             )
             if ("NextToken" in raw_result) and (len(new_output) > 0):
                 next_args["NextToken"] = raw_result["NextToken"]
@@ -296,7 +296,7 @@ def _fetch_metric(self, metric_name):
         }
         raw_cwm_data = self._cloudwatch.get_metric_statistics(**request)["Datapoints"]
         if len(raw_cwm_data) == 0:
-            logging.warning("Warning: No metrics called %s found" % metric_name)
+            logging.warning("Warning: No metrics called %s found", metric_name)
             return
 
         # Process data: normalize to starting time, and sort.

src/sagemaker/local/entities.py

@@ -427,10 +427,10 @@ def _wait_for_serving_container(serving_port):
         if i >= HEALTH_CHECK_TIMEOUT_LIMIT:
             raise RuntimeError("Giving up, endpoint didn't launch correctly")
 
-        logger.info("Checking if serving container is up, attempt: %s" % i)
+        logger.info("Checking if serving container is up, attempt: %s", i)
         _, code = _perform_request(endpoint_url, http)
         if code != 200:
-            logger.info("Container still not up, got: %s" % code)
+            logger.info("Container still not up, got: %s", code)
         else:
             return
 

src/sagemaker/local/image.py

@@ -619,7 +619,7 @@ def _check_output(cmd, *popenargs, **kwargs):
 
     output = output.decode("utf-8")
     if not success:
-        logger.error("Command output: %s" % output)
+        logger.error("Command output: %s", output)
         raise Exception("Failed to run %s" % ",".join(cmd))
 
     return output
@@ -639,9 +639,9 @@ def _delete_tree(path):
         # files. We expect this to happen, so we handle EACCESS. Any other error we will raise the
         # exception up.
         if exc.errno == errno.EACCES:
-            logger.warning("Failed to delete: %s Please remove it manually." % path)
+            logger.warning("Failed to delete: %s Please remove it manually.", path)
         else:
-            logger.error("Failed to delete: %s" % path)
+            logger.error("Failed to delete: %s", path)
             raise
 
 
@@ -680,7 +680,7 @@ def _aws_credentials(session):
             )
             return None
     except Exception as e:  # pylint: disable=broad-except
-        logger.info("Could not get AWS credentials: %s" % e)
+        logger.info("Could not get AWS credentials: %s", e)
 
     return None