revert: don't force automatic bucket creation if user don't specify it

Author: Malav Shastri

src/sagemaker/jumpstart/hub/hub.py

@@ -33,6 +33,8 @@
 from sagemaker.jumpstart.hub.utils import (
     get_hub_model_version,
     get_info_from_hub_resource_arn,
+    create_hub_bucket_if_it_does_not_exist,
+    generate_default_hub_bucket_name,
     create_s3_object_reference_from_uri,
     construct_hub_arn_from_name,
 )
@@ -88,23 +90,23 @@ def _fetch_hub_bucket_name(self) -> str:
             if hub_output_location:
                 location = create_s3_object_reference_from_uri(hub_output_location)
                 return location.bucket
+            default_bucket_name = generate_default_hub_bucket_name(self._sagemaker_session)
             JUMPSTART_LOGGER.warning(
-                "There is not a Hub bucket associated with %s.",
+                "There is not a Hub bucket associated with %s. Using %s",
                 self.hub_name,
             )
-            return None
+            return default_bucket_name
         except exceptions.ClientError:
+            hub_bucket_name = generate_default_hub_bucket_name(self._sagemaker_session)
             JUMPSTART_LOGGER.warning(
-                "There is not a Hub bucket associated with %s.",
+                "There is not a Hub bucket associated with %s. Using %s",
                 self.hub_name,
             )
-            return None
+            return hub_bucket_name
 
     def _generate_hub_storage_location(self, bucket_name: Optional[str] = None) -> None:
         """Generates an ``S3ObjectLocation`` given a Hub name."""
         hub_bucket_name = bucket_name or self._fetch_hub_bucket_name()
-        if hub_bucket_name is None:
-            return
         curr_timestamp = datetime.now().timestamp()
         return S3ObjectLocation(bucket=hub_bucket_name, key=f"{self.hub_name}-{curr_timestamp}")
 
@@ -127,18 +129,16 @@ def create(
     ) -> Dict[str, str]:
         """Creates a hub with the given description"""
 
-        s3_storage_config = (
-            {"S3OutputPath": self.hub_storage_location.get_uri()}
-            if self.hub_storage_location
-            else None
+        create_hub_bucket_if_it_does_not_exist(
+            self.hub_storage_location.bucket, self._sagemaker_session
         )
 
         return self._sagemaker_session.create_hub(
             hub_name=self.hub_name,
             hub_description=description,
             hub_display_name=display_name,
             hub_search_keywords=search_keywords,
-            s3_storage_config=s3_storage_config,
+            s3_storage_config={"S3OutputPath": self.hub_storage_location.get_uri()},
             tags=tags,
         )