Skip to content

Commit 34a6a31

Browse files
committed
fix unit-test
1 parent a64dace commit 34a6a31

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/sagemaker/telemetry/telemetry_logging.py

+6
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,9 @@ def wrapper(*args, **kwargs):
7676
"sagemaker_session", _get_default_sagemaker_session()
7777
)
7878

79+
print("sagemaker_session: ", sagemaker_session)
7980
if sagemaker_session:
81+
print("sagemaker_session found...")
8082
logger.debug("sagemaker_session found, preparing to emit telemetry...")
8183
logger.info(TELEMETRY_OPT_OUT_MESSAGING)
8284
response = None
@@ -149,6 +151,7 @@ def wrapper(*args, **kwargs):
149151
raise caught_ex
150152
return response # pylint: disable=W0150
151153
else:
154+
print("sagemaker_session not found")
152155
logger.debug(
153156
"Unable to send telemetry for function %s. "
154157
"sagemaker_session is not provided or not valid.",
@@ -185,10 +188,13 @@ def _send_telemetry_request(
185188
extra_info,
186189
)
187190
# Send the telemetry request
191+
print(f"\nSending telemetry request to [{url}]\n")
188192
logger.debug("Sending telemetry request to [%s]", url)
189193
_requests_helper(url, 2)
194+
print("Telemetry request sent...")
190195
logger.debug("SageMaker Python SDK telemetry successfully emitted.")
191196
except Exception: # pylint: disable=W0703
197+
print("SageMaker Python SDK telemetry not emitted!")
192198
logger.debug("SageMaker Python SDK telemetry not emitted!")
193199

194200

tests/unit/sagemaker/telemetry/test_telemetry_logging.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ def test_get_region_or_default_exception(self):
289289
def test_get_default_sagemaker_session(self):
290290
sagemaker_session = _get_default_sagemaker_session()
291291

292-
assert sagemaker_session is sagemaker.Session
292+
assert isinstance(sagemaker_session, sagemaker.Session) == True
293293
assert sagemaker_session.boto_session.region_name == "us-west-2"
294294

295295
@patch.object(boto3.Session, "region_name", None)

0 commit comments

Comments
 (0)