Skip to content

Commit 2f8ed41

Browse files
authored
fix: skip TF tests for unsupported versions (#5007)
* fix: skip TF tests for unsupported versions * flake8
1 parent 92b706a commit 2f8ed41

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

tests/integ/sagemaker/workflow/test_model_create_and_registration.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import pytest
2727

2828
from packaging.version import Version
29-
from packaging.specifiers import SpecifierSet
3029

3130
from sagemaker.model_card.model_card import ModelCard, ModelOverview, ModelPackageModelCard
3231
from sagemaker.model_card.schema_constraints import ModelCardStatusEnum
@@ -1422,7 +1421,7 @@ def test_model_registration_with_tensorflow_model_with_pipeline_model(
14221421
pipeline_name,
14231422
region_name,
14241423
):
1425-
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
1424+
if Version(tf_full_version) >= Version("2.16"):
14261425
pytest.skip(
14271426
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
14281427
"https://github.com/tensorflow/io/issues/2039"

tests/integ/sagemaker/workflow/test_model_steps.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import pytest
1919

2020
from packaging.version import Version
21-
from packaging.specifiers import SpecifierSet
2221

2322
from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution
2423
from sagemaker.workflow.fail_step import FailStep
@@ -592,7 +591,7 @@ def test_model_registration_with_drift_check_baselines_and_model_metrics(
592591
def test_model_registration_with_tensorflow_model_with_pipeline_model(
593592
pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name
594593
):
595-
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
594+
if Version(tf_full_version) >= Version("2.16"):
596595
pytest.skip(
597596
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
598597
"https://github.com/tensorflow/io/issues/2039"

tests/integ/sagemaker/workflow/test_training_steps.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import pytest
2020

2121
from packaging.version import Version
22-
from packaging.specifiers import SpecifierSet
2322

2423
from tests.integ.sagemaker.workflow.helpers import wait_pipeline_execution
2524
from sagemaker import TrainingInput, get_execution_role, utils, image_uris
@@ -238,7 +237,7 @@ def test_training_step_with_output_path_as_join(
238237
def test_tensorflow_training_step_with_parameterized_code_input(
239238
pipeline_session, role, tf_full_version, tf_full_py_version, pipeline_name
240239
):
241-
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
240+
if Version(tf_full_version) >= Version("2.16"):
242241
pytest.skip(
243242
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
244243
"https://github.com/tensorflow/io/issues/2039"

tests/integ/test_transformer.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
import pytest
2020

2121
from packaging.version import Version
22-
from packaging.specifiers import SpecifierSet
2322

2423
from sagemaker import KMeans, s3, get_execution_role
2524
from sagemaker.mxnet import MXNet
@@ -556,7 +555,7 @@ def test_transform_mxnet_logs(
556555
def test_transform_tf_kms_network_isolation(
557556
sagemaker_session, cpu_instance_type, tmpdir, tf_full_version, tf_full_py_version
558557
):
559-
if Version(tf_full_version) in SpecifierSet("==2.16.*"):
558+
if Version(tf_full_version) >= Version("2.16"):
560559
pytest.skip(
561560
"This test is failing in TensorFlow 2.16 beacuse of an upstream bug: "
562561
"https://github.com/tensorflow/io/issues/2039"

0 commit comments

Comments
 (0)