Skip to content

Commit 1d98b72

Browse files
pr review feedback changes
1 parent e30fd70 commit 1d98b72

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/sagemaker/workflow/emr_step.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,13 @@ def __init__(
7373
depends_on: List[str] = None,
7474
cache_config: CacheConfig = None,
7575
):
76-
"""Constructs a LambdaStep.
76+
"""Constructs a EMRStep.
7777
7878
Args:
7979
name(str): The name of the EMR step.
8080
display_name(str): The display name of the EMR step.
8181
description(str): The description of the EMR step.
82-
cluster_id(str): A string that uniquely identifies the cluster.
82+
cluster_id(str): The ID of the running EMR cluster.
8383
step_config(EMRStepConfig): One StepConfig to be executed by the job flow.
8484
depends_on(List[str]):
8585
A list of step names this `sagemaker.workflow.steps.EMRStep` depends on

tests/integ/test_workflow.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@ def emr_cluster_id(sagemaker_session, role):
298298
cluster_id = get_existing_emr_cluster_id(emr_client, cluster_name)
299299

300300
if cluster_id is None:
301-
create_new_emr_cluster(sagemaker_session, emr_client, cluster_name)
301+
cluster_id = create_new_emr_cluster(sagemaker_session, emr_client, cluster_name)
302302
return cluster_id
303303

304304

@@ -310,6 +310,7 @@ def get_existing_emr_cluster_id(emr_client, cluster_name):
310310
cluster_id = cluster["Id"]
311311
print("Using existing cluster: {}".format(cluster_id))
312312
return cluster_id
313+
return None
313314
except Exception:
314315
raise
315316

0 commit comments

Comments
 (0)