Merge branch 'master' into use-custom-exception-subclass

Author: laurenyu

.pylintrc

@@ -19,9 +19,11 @@ profile=no
 # paths.
 ignore=CVS,tensorflow_serving
 
-# Add files or directories matching the regex patterns to the blacklist. The
-# regex matches against base names, not paths.
+# Add files or directories matching the regex patterns to the blacklist.
+# The regex matches against base names, not paths.
+# Regex patterns can be comma(and newline)-separated
 ignore-patterns=
+    .*_pb2.py, # Ignore all files generated by the protocol buffer compiler
 
 # Pickle collected data for later comparisons.
 persistent=yes
@@ -81,30 +83,14 @@ disable=
     too-many-arguments,
     invalid-name,
     too-many-instance-attributes,
-    line-too-long, # We let Flake8 take care of this # TODO: Fix these and stop relying on flake8
     len-as-condition, # TODO: Enable this check once pylint 2.4.0 is released and consumed due to the fix in https://github.com/PyCQA/pylint/issues/2684
-    import-error, # TODO: Fix import errors
-    attribute-defined-outside-init, # TODO: Fix scope
+    import-error, # Since we run Pylint before any of our builds in tox, this will always fail
     protected-access, # TODO: Fix access
     abstract-method, # TODO: Fix abstract methods
-    unidiomatic-typecheck, # TODO: Fix typechecks
-    wrong-import-order, # TODO: Fix import order
-    no-else-return, # TODO: Remove unnecessary elses
-    useless-object-inheritance, # TODO: Remove unnecessary imports
+    useless-object-inheritance, # TODO: Enable this check and fix code once Python 2 is no longer supported.
     cyclic-import, # TODO: Resolve cyclic imports
-    no-else-raise, # TODO: Remove unnecessary elses
     no-self-use, # TODO: Convert methods to functions where appropriate
-    inconsistent-return-statements, # TODO: Make returns consistent
-    consider-merging-isinstance, # TODO: Merge isinstance where appropriate
-    consider-using-in, # TODO: Consider merging comparisons with "in"
-    simplifiable-if-expression, # TODO: Simplify expressions
-    too-many-public-methods, # TODO: Resolve
-    ungrouped-imports, # TODO: Group imports
-    consider-using-ternary, # TODO: Consider ternary expressions
-    chained-comparison, # TODO: Simplify chained comparison between operands
-    simplifiable-if-statement, # TODO: Simplify ifs
     too-many-branches, # TODO: Simplify or ignore as appropriate
-    missing-docstring, # TODO: Fix missing docstring
 
 [REPORTS]
 # Set the output format. Available formats are text, parseable, colorized, msvs
@@ -241,8 +227,9 @@ max-nested-blocks=5
 # Maximum number of characters on a single line.
 max-line-length=100
 
-# Regexp for a line that is allowed to be longer than the limit.
-ignore-long-lines=^\s*(# )?<?https?://\S+>?$
+# Regexp for a line that is allowed to be longer than the limit. Can only be a single regex.
+# The following matches any semblance of a url of any sort.
+ignore-long-lines=^\s*.*(# )?(<?https?:\/\/)?[-a-zA-Z0-9@:%%._\+~#=><]{1,256}\.[a-zA-Z0-9()]{1,6}\b[-a-zA-Z0-9()@:%%_\+.~#?&\/\/=<>]*\S*>?$
 
 # Allow the body of an if to be on the same line as the test if there is no
 # else.

CHANGELOG.md

@@ -1,5 +1,49 @@
 # Changelog
 
+## v1.34.0 (2019-07-18)
+
+### Features
+
+ * Git integration for CodeCommit
+ * deal with credentials for Git support for GitHub
+
+### Bug fixes and other changes
+
+ * modify TODO on disabled Pylint check
+ * enable consider-using-ternary Pylint check
+ * enable chained-comparison Pylint check
+ * enable too-many-public-methods Pylint check
+ * enable consider-using-in Pylint check
+ * set num_processes_per_host only if provided by user
+ * fix attach for 1P algorithm estimators
+ * enable ungrouped-imports Pylint check
+ * enable wrong-import-order Pylint check
+ * enable attribute-defined-outside-init Pylint check
+ * enable consider-merging-isinstance Pylint check
+ * enable inconsistent-return-statements Pylint check
+ * enable simplifiable-if-expression pylint checks
+ * fix list serialization for 1P algos
+ * enable no-else-return and no-else-raise pylint checks
+ * enable unidiomatic-typecheck pylint check
+
+## v1.33.0 (2019-07-10)
+
+### Features
+
+ * git support for hosting models
+ * allow custom model name during deploy
+
+### Bug fixes and other changes
+
+ * remove TODO comment on import-error Pylint check
+ * enable wrong-import-position pylint check
+ * Revert "change: enable wrong-import-position pylint check (#907)"
+ * enable signature-differs pylint check
+ * enable wrong-import-position pylint check
+ * enable logging-not-lazy pylint check
+ * reset default output path in Transformer.transform
+ * Add ap-northeast-1 to Neo algorithms region map
+
 ## v1.32.2 (2019-07-08)
 
 ### Bug fixes and other changes

CONTRIBUTING.md

@@ -19,6 +19,23 @@ reported the issue. Please try to include as much information as you can. Detail
 * Any modifications you've made relevant to the bug
 * A description of your environment or deployment
 
+## Setting up your development environment [optional, but recommended]
+
+* Set up the Cloud9 environment:
+  * Instance type: You'll need at least 4 GB of RAM to avoid running into memory issues. We recommend at least a t3.medium to run the unit tests. Larger hosts will reduce the chance of encountering resource limits.
+  * Follow the instructions at [Creating a Cloud9 EC2 Environment](https://docs.aws.amazon.com/cloud9/latest/user-guide/create-environment.html#create-environment-main) to set up a Cloud9 EC2 environment
+* Expand the storage of the EC2 instance from 10GB to 20GB
+  * Because you'll need a minimum of 11GB of disk storage on the EC2 instance to run the package's unit tests, you'll need to expand your EC2 volume size. We recommend at least 20GB. A larger volume will reduce the chance of encountering resource limits. 
+  * Follow the instructions at [Modifying an EBS Volume Using Elastic Volumes (Console)](https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/requesting-ebs-volume-modifications.html#modify-ebs-volume) to increase the EBS volume size associated with the newly created EC2 instance.
+  * Wait 5-10min for the new EBS volume increase to take effect.
+  * Allow EC2 to claim the additional space by stopping and then starting your EC2 host.
+* Create a fork of this package on GitHub. You should end up with a fork at `https://github.com/<username>/sagemaker-python-sdk`
+  * Follow the instructions at [Fork a repo](https://help.github.com/en/articles/fork-a-repo) to fork a GitHub repository.
+* In the Cloud9 UI, pull down this package by clicking on "Clone from Github" or running the following command in the Cloud9 terminal: `git clone https://github.com/<username>/sagemaker-python-sdk` where <username> is your github username.
+* Install tox using `pip install tox`
+* Install coverage using `pip install .[test]`
+* cd into the sagemaker-python-sdk package: `cd sagemaker-python-sdk` or `cd /environment/sagemaker-python-sdk`
+* Run the following tox command and verify that all unit tests pass: `tox tests/unit`
 
 ## Contributing via Pull Requests
 Contributions via pull requests are much appreciated. 

README.rst

@@ -173,9 +173,9 @@ MXNet SageMaker Estimators
 
 By using MXNet SageMaker Estimators, you can train and host MXNet models on Amazon SageMaker.
 
-Supported versions of MXNet: ``0.12.1``, ``1.0.0``, ``1.1.0``, ``1.2.1``, ``1.3.0``, ``1.4.0``.
+Supported versions of MXNet: ``0.12.1``, ``1.0.0``, ``1.1.0``, ``1.2.1``, ``1.3.0``, ``1.4.0``, ``1.4.1``.
 
-Supported versions of MXNet for Elastic Inference: ``1.3.0``, ``1.4.0``.
+Supported versions of MXNet for Elastic Inference: ``1.3.0``, ``1.4.0``, ``1.4.1``.
 
 We recommend that you use the latest supported version, because that's where we focus most of our development efforts.
 
@@ -191,7 +191,7 @@ By using TensorFlow SageMaker Estimators, you can train and host TensorFlow mode
 
 Supported versions of TensorFlow: ``1.4.1``, ``1.5.0``, ``1.6.0``, ``1.7.0``, ``1.8.0``, ``1.9.0``, ``1.10.0``, ``1.11.0``, ``1.12.0``, ``1.13.1``.
 
-Supported versions of TensorFlow for Elastic Inference: ``1.11.0``, ``1.12.0``.
+Supported versions of TensorFlow for Elastic Inference: ``1.11.0``, ``1.12.0``, ``1.13.0``
 
 We recommend that you use the latest supported version, because that's where we focus most of our development efforts.
 
@@ -221,7 +221,7 @@ PyTorch SageMaker Estimators
 
 With PyTorch SageMaker Estimators, you can train and host PyTorch models on Amazon SageMaker.
 
-Supported versions of PyTorch: ``0.4.0``, ``1.0.0``.
+Supported versions of PyTorch: ``0.4.0``, ``1.0.0``, ``1.1.0``.
 
 We recommend that you use the latest supported version, because that's where we focus most of our development efforts.
 

VERSION

@@ -1 +1 @@
-1.32.3.dev0
+1.34.1.dev0

doc/conf.py

@@ -10,6 +10,7 @@
 # distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF
 # ANY KIND, either express or implied. See the License for the specific
 # language governing permissions and limitations under the License.
+"""Placeholder docstring"""
 from __future__ import absolute_import
 
 import os
@@ -22,6 +23,10 @@
 class Mock(MagicMock):
     @classmethod
     def __getattr__(cls, name):
+        """
+        Args:
+            name:
+        """
         if name == "__version__":
             return "1.4.0"
         else:
@@ -55,6 +60,7 @@ def __getattr__(cls, name):
     "sphinx.ext.coverage",
     "sphinx.ext.autosummary",
     "sphinx.ext.napoleon",
+    "sphinx.ext.autosectionlabel",
 ]
 
 # Add any paths that contain templates here, relative to this directory.
@@ -90,3 +96,6 @@ def __getattr__(cls, name):
 
 # autosummary
 autosummary_generate = True
+
+# autosectionlabel
+autosectionlabel_prefix_document = True