Skip to content

Commit 1b4c2b1

Browse files
authored
change: enable consider-merging-isinstance Pylint check (#932)
Note that this commit will also enable simplifiable-if-statement, as there are no code changes needed for it.
1 parent 01ed740 commit 1b4c2b1

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

.pylintrc

-2
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,11 @@ disable=
9191
useless-object-inheritance, # TODO: Remove unnecessary imports
9292
cyclic-import, # TODO: Resolve cyclic imports
9393
no-self-use, # TODO: Convert methods to functions where appropriate
94-
consider-merging-isinstance, # TODO: Merge isinstance where appropriate
9594
consider-using-in, # TODO: Consider merging comparisons with "in"
9695
too-many-public-methods, # TODO: Resolve
9796
ungrouped-imports, # TODO: Group imports
9897
consider-using-ternary, # TODO: Consider ternary expressions
9998
chained-comparison, # TODO: Simplify chained comparison between operands
100-
simplifiable-if-statement, # TODO: Simplify ifs
10199
too-many-branches, # TODO: Simplify or ignore as appropriate
102100
missing-docstring, # TODO: Fix missing docstring
103101

src/sagemaker/tuner.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ def fit(self, inputs=None, job_name=None, include_cls_metadata=False, **kwargs):
307307
**kwargs: Other arguments needed for training. Please refer to the ``fit()`` method of the associated
308308
estimator to see what other arguments are needed.
309309
"""
310-
if isinstance(inputs, list) or isinstance(inputs, RecordSet):
310+
if isinstance(inputs, (list, RecordSet)):
311311
self.estimator._prepare_for_training(inputs, **kwargs)
312312
else:
313313
self.estimator._prepare_for_training(job_name)

0 commit comments

Comments
 (0)