Skip to content

Commit 1aec497

Browse files
whiletruelearnnadiaya
authored andcommitted
BYO Algorithm training should have support for vpc (#370)
* vpc config should be initialized for Estimator * add tags also to signature * Add change log and docstring
1 parent 4add5fc commit 1aec497

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

CHANGELOG.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ CHANGELOG
66
========
77

88
* bug-fix: Local Mode: Create output/data directory expected by SageMaker Container.
9+
* bug-fix: Estimator accepts the vpc configs made capable by 1.9.1
910

1011
1.9.2
1112
=====

src/sagemaker/estimator.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -429,7 +429,7 @@ class Estimator(EstimatorBase):
429429
def __init__(self, image_name, role, train_instance_count, train_instance_type,
430430
train_volume_size=30, train_max_run=24 * 60 * 60, input_mode='File',
431431
output_path=None, output_kms_key=None, base_job_name=None, sagemaker_session=None,
432-
hyperparameters=None):
432+
hyperparameters=None, tags=None, subnets=None, security_group_ids=None):
433433
"""Initialize an ``Estimator`` instance.
434434
435435
Args:
@@ -467,7 +467,8 @@ def __init__(self, image_name, role, train_instance_count, train_instance_type,
467467
self.hyperparam_dict = hyperparameters.copy() if hyperparameters else {}
468468
super(Estimator, self).__init__(role, train_instance_count, train_instance_type,
469469
train_volume_size, train_max_run, input_mode,
470-
output_path, output_kms_key, base_job_name, sagemaker_session)
470+
output_path, output_kms_key, base_job_name, sagemaker_session,
471+
tags, subnets, security_group_ids)
471472

472473
def train_image(self):
473474
"""

0 commit comments

Comments
 (0)