Skip to content

Commit 17dd24e

Browse files
evakravievakravi
committed
chore: make sagemaker.jumpstart.accessor.JumpStartModelsAccessor.get_manifest private (add underscore prefix)
1 parent a65e255 commit 17dd24e

File tree

4 files changed

+18
-18
lines changed

4 files changed

+18
-18
lines changed

‎src/sagemaker/jumpstart/accessors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ def _set_cache_and_region(region: str, cache_kwargs: dict) -> None:
7979
JumpStartModelsAccessor._curr_region = region
8080

8181
@staticmethod
82-
def get_manifest(region: str = JUMPSTART_DEFAULT_REGION_NAME) -> List[JumpStartModelHeader]:
82+
def _get_manifest(region: str = JUMPSTART_DEFAULT_REGION_NAME) -> List[JumpStartModelHeader]:
8383
"""Return entire JumpStart models manifest.
8484
8585
Raises:

‎src/sagemaker/jumpstart/notebook_utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ def _generate_jumpstart_model_versions( # pylint: disable=redefined-builtin
284284
if isinstance(filter, str):
285285
filter = Identity(filter)
286286

287-
models_manifest_list = accessors.JumpStartModelsAccessor.get_manifest(region=region)
287+
models_manifest_list = accessors.JumpStartModelsAccessor._get_manifest(region=region)
288288
manifest_keys = set(models_manifest_list[0].__slots__)
289289

290290
all_keys: Set[str] = set()

‎tests/unit/sagemaker/jumpstart/test_accessors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_jumpstart_models_cache_get_fxs(mock_cache):
5555
region="us-west-2", model_id="pytorch-ic-mobilenet-v2", version="*"
5656
)
5757

58-
assert len(accessors.JumpStartModelsAccessor.get_manifest()) > 0
58+
assert len(accessors.JumpStartModelsAccessor._get_manifest()) > 0
5959

6060
# necessary because accessors is a static module
6161
reload(accessors)

‎tests/unit/sagemaker/jumpstart/test_notebook_utils.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
)
2323

2424

25-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
25+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
2626
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
2727
@patch("sagemaker.jumpstart.notebook_utils._generate_jumpstart_model_versions")
2828
def test_list_jumpstart_scripts(
@@ -66,7 +66,7 @@ def test_list_jumpstart_scripts(
6666
assert patched_get_model_specs.call_count == len(PROTOTYPICAL_MODEL_SPECS_DICT)
6767

6868

69-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
69+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
7070
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
7171
@patch("sagemaker.jumpstart.notebook_utils._generate_jumpstart_model_versions")
7272
def test_list_jumpstart_tasks(
@@ -106,7 +106,7 @@ def test_list_jumpstart_tasks(
106106
patched_get_model_specs.assert_not_called()
107107

108108

109-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
109+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
110110
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
111111
@patch("sagemaker.jumpstart.notebook_utils._generate_jumpstart_model_versions")
112112
def test_list_jumpstart_frameworks(
@@ -161,7 +161,7 @@ def test_list_jumpstart_frameworks(
161161

162162

163163
class ListJumpStartModels(TestCase):
164-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
164+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
165165
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
166166
def test_list_jumpstart_models_simple_case(
167167
self, patched_get_model_specs: Mock, patched_get_manifest: Mock
@@ -182,7 +182,7 @@ def test_list_jumpstart_models_simple_case(
182182
patched_get_manifest.assert_called()
183183
patched_get_model_specs.assert_not_called()
184184

185-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
185+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
186186
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
187187
def test_list_jumpstart_models_script_filter(
188188
self, patched_get_model_specs: Mock, patched_get_manifest: Mock
@@ -232,7 +232,7 @@ def test_list_jumpstart_models_script_filter(
232232
assert patched_get_model_specs.call_count == manifest_length
233233
patched_get_manifest.assert_called_once()
234234

235-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
235+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
236236
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
237237
def test_list_jumpstart_models_task_filter(
238238
self, patched_get_model_specs: Mock, patched_get_manifest: Mock
@@ -287,7 +287,7 @@ def test_list_jumpstart_models_task_filter(
287287
patched_get_model_specs.assert_not_called()
288288
patched_get_manifest.assert_called_once()
289289

290-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
290+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
291291
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
292292
def test_list_jumpstart_models_framework_filter(
293293
self, patched_get_model_specs: Mock, patched_get_manifest: Mock
@@ -367,7 +367,7 @@ def test_list_jumpstart_models_framework_filter(
367367
patched_get_model_specs.assert_not_called()
368368
patched_get_manifest.assert_called_once()
369369

370-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
370+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
371371
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
372372
def test_list_jumpstart_models_region(
373373
self, patched_get_model_specs: Mock, patched_get_manifest: Mock
@@ -380,7 +380,7 @@ def test_list_jumpstart_models_region(
380380

381381
patched_get_manifest.assert_called_once_with(region="some-region")
382382

383-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
383+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
384384
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
385385
@patch("sagemaker.jumpstart.notebook_utils.get_sagemaker_version")
386386
def test_list_jumpstart_models_unsupported_models(
@@ -412,7 +412,7 @@ def test_list_jumpstart_models_unsupported_models(
412412
assert [] != list_jumpstart_models("training_supported in [False, True]")
413413
patched_get_model_specs.assert_called()
414414

415-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
415+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
416416
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
417417
def test_list_jumpstart_models_old_models(
418418
self,
@@ -483,7 +483,7 @@ def get_manifest_more_versions(region: str = JUMPSTART_DEFAULT_REGION_NAME):
483483
list_old_models=False, list_versions=True
484484
) == list_jumpstart_models(list_versions=True)
485485

486-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
486+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
487487
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
488488
def test_list_jumpstart_models_vulnerable_models(
489489
self,
@@ -532,7 +532,7 @@ def vulnerable_training_model_spec(*args, **kwargs):
532532

533533
assert patched_get_model_specs.call_count == 0
534534

535-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
535+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
536536
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
537537
def test_list_jumpstart_models_deprecated_models(
538538
self,
@@ -562,7 +562,7 @@ def deprecated_model_spec(*args, **kwargs):
562562

563563
assert patched_get_model_specs.call_count == 0
564564

565-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
565+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
566566
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
567567
def test_list_jumpstart_models_no_versions(
568568
self,
@@ -587,7 +587,7 @@ def test_list_jumpstart_models_no_versions(
587587

588588
assert list_jumpstart_models(list_versions=False) == all_model_ids
589589

590-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
590+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
591591
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
592592
def test_list_jumpstart_models_complex_queries(
593593
self,
@@ -630,7 +630,7 @@ def test_list_jumpstart_models_complex_queries(
630630
)
631631
) == ["tensorflow-ic-bit-m-r101x1-ilsvrc2012-classification-1"]
632632

633-
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_manifest")
633+
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor._get_manifest")
634634
@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
635635
def test_list_jumpstart_models_multiple_level_index(
636636
self,

0 commit comments

Comments
 (0)