Skip to content

Commit 1316b63

Browse files
authored
change: remove hardcoded creds from integ test (#1029)
1 parent c364fd1 commit 1316b63

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tests/integ/test_git.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -233,14 +233,15 @@ def test_git_support_with_sklearn_ssh_passphrase_not_configured(
233233

234234

235235
@pytest.mark.local_mode
236+
@pytest.mark.skip("needs a secure authentication approach")
236237
def test_git_support_codecommit_with_mxnet(sagemaker_local_session):
237238
script_path = "mnist.py"
238239
data_path = os.path.join(DATA_DIR, "mxnet_mnist")
239240
git_config = {
240241
"repo": CODECOMMIT_REPO,
241242
"branch": CODECOMMIT_BRANCH,
242243
"username": "GitTest-at-142577830533",
243-
"password": "22LcZpWMtjpDG3fbOuHPooIoKoRxF36rQj7zdUvXooA=",
244+
"password": "", # TODO: assume a role to get temporary credentials
244245
}
245246
source_dir = "mxnet"
246247
dependencies = ["foo/bar.py"]

0 commit comments

Comments
 (0)