Skip to content

Commit 1266139

Browse files
authored
Merge branch 'master' into minor-updates-to-clarify-api-doc
2 parents 74201e0 + 212a777 commit 1266139

File tree

4 files changed

+7
-9
lines changed

4 files changed

+7
-9
lines changed

src/sagemaker/dataset_definition/inputs.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -99,9 +99,9 @@ class DatasetDefinition(ApiObject):
9999
Definition inputs to run a processing job. LocalPath is an absolute path to the input
100100
data. This is a required parameter when `AppManaged` is False (default).
101101
redshift_dataset_definition
102-
(:class:`~sagemaker.dataset_definition.RedshiftDatasetDefinition`): Redshift
102+
(:class:`~sagemaker.dataset_definition.inputs.RedshiftDatasetDefinition`): Redshift
103103
dataset definition.
104-
athena_dataset_definition (:class:`~sagemaker.dataset_definition.AthenaDatasetDefinition`):
104+
athena_dataset_definition (:class:`~sagemaker.dataset_definition.inputs.AthenaDatasetDefinition`):
105105
Configuration for Athena Dataset Definition input.
106106
"""
107107

src/sagemaker/processing.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1065,9 +1065,9 @@ def __init__(
10651065
s3_data_distribution_type (str): Valid options are "FullyReplicated"
10661066
or "ShardedByS3Key".
10671067
s3_compression_type (str): Valid options are "None" or "Gzip".
1068-
s3_input (:class:`~sagemaker.dataset_definition.S3Input`)
1068+
s3_input (:class:`~sagemaker.dataset_definition.inputs.S3Input`)
10691069
Metadata of data objects stored in S3
1070-
dataset_definition (:class:`~sagemaker.dataset_definition.DatasetDefinition`)
1070+
dataset_definition (:class:`~sagemaker.dataset_definition.inputs.DatasetDefinition`)
10711071
DatasetDefinition input
10721072
app_managed (bool): Whether the input are managed by SageMaker or application
10731073
"""

tests/integ/test_feature_store.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -312,4 +312,4 @@ def cleanup_feature_group(feature_group: FeatureGroup):
312312
try:
313313
feature_group.delete()
314314
except Exception:
315-
pass
315+
raise RuntimeError(f"Failed to delete feature group with name {feature_group.name}")

tests/integ/test_processing.py

+2-4
Original file line numberDiff line numberDiff line change
@@ -162,6 +162,7 @@ def test_sklearn_with_customizations(
162162
sklearn_processor = SKLearnProcessor(
163163
framework_version=sklearn_latest_version,
164164
role=ROLE,
165+
command=["python3"],
165166
instance_type=cpu_instance_type,
166167
instance_count=1,
167168
volume_size_in_gb=100,
@@ -287,10 +288,6 @@ def test_sklearn_with_custom_default_bucket(
287288

288289
assert job_description["ProcessingInputs"][0]["InputName"] == "dummy_input"
289290
assert custom_bucket_name in job_description["ProcessingInputs"][0]["S3Input"]["S3Uri"]
290-
291-
assert job_description["ProcessingInputs"][2]["InputName"] == "entrypoint"
292-
assert custom_bucket_name in job_description["ProcessingInputs"][2]["S3Input"]["S3Uri"]
293-
294291
assert job_description["ProcessingJobName"].startswith("test-sklearn-with-customizations")
295292

296293
assert job_description["ProcessingJobStatus"] == "Completed"
@@ -680,6 +677,7 @@ def test_sklearn_with_network_config(sagemaker_session, sklearn_latest_version,
680677
sklearn_processor = SKLearnProcessor(
681678
framework_version=sklearn_latest_version,
682679
role=ROLE,
680+
command=["python3"],
683681
instance_type=cpu_instance_type,
684682
instance_count=1,
685683
sagemaker_session=sagemaker_session,

0 commit comments

Comments
 (0)