Skip to content

Commit 1029251

Browse files
Yongyan Raonavinsoni
Yongyan Rao
authored andcommitted
Add unit tests
1 parent 08b3093 commit 1029251

File tree

1 file changed

+34
-0
lines changed

1 file changed

+34
-0
lines changed

tests/unit/test_fw_utils.py

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,15 @@ def sagemaker_session():
4949
session_mock.sagemaker_client.describe_training_job = Mock(
5050
return_value={"ModelArtifacts": {"S3ModelArtifacts": "s3://m/m.tar.gz"}}
5151
)
52+
session_mock.boto_session.client("ec2").describe_instance_types = Mock(
53+
return_value={
54+
"InstanceTypes": [
55+
{
56+
"CpuInfo": {},
57+
},
58+
],
59+
}
60+
)
5261
return session_mock
5362

5463

@@ -733,6 +742,31 @@ def test_validate_smdistributed_not_raises():
733742
)
734743

735744

745+
def test_validate_distribution_instance_no_smdistributed(sagemaker_session):
746+
distribution = {}
747+
instance_type = "mock_type"
748+
fw_utils.validate_distribution_instance(sagemaker_session, distribution, instance_type)
749+
750+
751+
def test_validate_distribution_instance_no_modelparallel(sagemaker_session):
752+
distribution = {"smdistributed": {}}
753+
instance_type = "mock_type"
754+
fw_utils.validate_distribution_instance(sagemaker_session, distribution, instance_type)
755+
756+
757+
def test_validate_distribution_instance_disabled_modelparallel(sagemaker_session):
758+
distribution = {"smdistributed": {"modelparallel": {"enabled": False}}}
759+
instance_type = "mock_type"
760+
fw_utils.validate_distribution_instance(sagemaker_session, distribution, instance_type)
761+
762+
763+
def test_validate_distribution_instance_raise(sagemaker_session):
764+
distribution = {"smdistributed": {"modelparallel": {"enabled": True}}}
765+
instance_type = "mock_type"
766+
with pytest.raises(ValueError):
767+
fw_utils.validate_distribution_instance(sagemaker_session, distribution, instance_type)
768+
769+
736770
def test_validate_smdistributed_raises():
737771
bad_args = [
738772
{"smdistributed": "dummy"},

0 commit comments

Comments
 (0)