breaking: updates based on PR feedback

Author: metrizable

src/sagemaker/fw_utils.py

@@ -690,12 +690,12 @@ def validate_version_or_image_args(framework_version, py_version, image_name):
 
     Args:
         framework_version (str): The version of the framework.
-        py_version (str): The version of python.
+        py_version (str): The version of Python.
         image_name (str): The URI of the image.
 
     Raises:
         ValueError: if `image_name` is None and either `framework_version` or `py_version` is
-                        None.
+            None.
     """
     if (framework_version is None or py_version is None) and image_name is None:
         raise ValueError(

src/sagemaker/mxnet/model.py

@@ -88,15 +88,15 @@ def __init__(
                 must point to a file located at the root of ``source_dir``.
             framework_version (str): MXNet version you want to use for executing
                 your model training code. Defaults to ``None``. Required unless
-                ``image_name`` is provided.
+                ``image`` is provided.
             py_version (str): Python version you want to use for executing your
                 model training code. Defaults to ``None``. Required unless
-                ``image_name`` is provided.
+                ``image`` is provided.
             image (str): A Docker image URI (default: None). If not specified, a
                 default image for MXNet will be used.
 
                 If ``framework_version`` or ``py_version`` are ``None``, then
-                ``image_name`` is required. If also ``None``, then a ``ValueError``
+                ``image`` is required. If also ``None``, then a ``ValueError``
                 will be raised.
             predictor_cls (callable[str, sagemaker.session.Session]): A function
                 to call to create a predictor with an endpoint name and

tests/unit/test_fw_utils.py

@@ -1274,13 +1274,10 @@ def test_warn_if_parameter_server_with_multi_gpu(caplog):
     assert fw_utils.PARAMETER_SERVER_MULTI_GPU_WARNING in caplog.text
 
 
-def test_validate_version_or_image_args():
+def test_validate_version_or_image_args_not_raises():
     good_args = [("1.0", "py3", None), (None, "py3", "my:uri"), ("1.0", None, "my:uri")]
     for framework_version, py_version, image_name in good_args:
-        assert (
-            fw_utils.validate_version_or_image_args(framework_version, py_version, image_name)
-            is None
-        )
+        fw_utils.validate_version_or_image_args(framework_version, py_version, image_name)
 
 
 def test_validate_version_or_image_args_raises():