Skip to content

Commit a1582bf

Browse files
authored
fix: @jsii/check-node crashes on loading with older node releases (#3588)
1 parent de3fc03 commit a1582bf

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

packages/@jsii/check-node/src/constants.ts

-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ export class NodeRelease {
2727
// Past end-of-life releases
2828
new NodeRelease(13, { endOfLife: new Date('2020-06-01') }),
2929
new NodeRelease(15, { endOfLife: new Date('2021-06-01') }),
30-
31-
// Deprecated releases
3230
new NodeRelease(12, {
3331
endOfLife: new Date('2022-04-30'),
3432
supportedRange: '^12.7.0',
+7-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
{
22
"extends": "../../../tsconfig-base",
33
"compilerOptions": {
4+
"target": "es2018", // Needs to target older releases of node or else it'll crash on start when using those
45
"outDir": "./lib",
56
"rootDir": "./src",
67
},
7-
"include": ["src/**/*.ts"],
8-
"exclude": ["jest.config.ts"],
8+
"include": [
9+
"src/**/*.ts"
10+
],
11+
"exclude": [
12+
"jest.config.ts"
13+
],
914
}

packages/@jsii/runtime/webpack.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module.exports = {
1818
iife: false,
1919
},
2020
devtool: 'source-map',
21-
target: 'node14.5',
21+
target: 'node12', // Continue to target node 12 so that check-node does not fail to load on it.
2222
node: {
2323
global: false,
2424
__filename: false,

0 commit comments

Comments
 (0)