revert: do not use node: protocol for imports (#3651)

It requires node 14.18.0 or greater, which is way more recent than
the earliest node engine we claim to support.



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0

Author: RomainMuller

eslint-config.yaml

@@ -8,7 +8,6 @@ plugins:
   - '@typescript-eslint'
   - import
   - prettier
-  - unicorn
 
 parser: '@typescript-eslint/parser'
 parserOptions:
@@ -44,9 +43,6 @@ rules:
   'prettier/prettier':
     - error
 
-  'unicorn/prefer-node-protocol':
-    - error
-
   '@typescript-eslint/array-type':
     - error
     - default: array-simple

package.json

@@ -27,7 +27,6 @@
     "eslint-import-resolver-typescript": "^3.2.4",
     "eslint-plugin-import": "^2.26.0",
     "eslint-plugin-prettier": "^4.2.1",
-    "eslint-plugin-unicorn": "^43.0.0",
     "jest": "^28.1.2",
     "jest-circus": "^28.1.2",
     "jest-config": "^28.1.2",

packages/@jsii/benchmarks/bin/benchmark.ts

@@ -1,5 +1,5 @@
 import * as fs from 'fs-extra';
-import * as path from 'node:path';
+import * as path from 'path';
 import * as yargs from 'yargs';
 
 import { benchmarks } from '../lib';

packages/@jsii/benchmarks/lib/benchmark.ts

@@ -1,9 +1,5 @@
-import { Profiler, Session } from 'node:inspector';
-import {
-  performance,
-  PerformanceObserver,
-  PerformanceEntry,
-} from 'node:perf_hooks';
+import { Profiler, Session } from 'inspector';
+import { performance, PerformanceObserver, PerformanceEntry } from 'perf_hooks';
 
 /**
  * Result of a single run of the subject

packages/@jsii/benchmarks/lib/constants.ts

@@ -1,4 +1,4 @@
-import * as path from 'node:path';
+import * as path from 'path';
 
 export const fixturesDir = path.resolve(__dirname, '..', 'fixtures');
 

packages/@jsii/benchmarks/lib/suite/aws-cdk-lib/build-with-jsii.ts

@@ -1,7 +1,7 @@
 import { Compiler } from 'jsii/lib/compiler';
 import { loadProjectInfo } from 'jsii/lib/project-info';
-import * as path from 'node:path';
-import * as process from 'node:process';
+import * as path from 'path';
+import * as process from 'process';
 import * as ts from 'typescript';
 
 import type { Context } from '.';

packages/@jsii/benchmarks/lib/suite/aws-cdk-lib/build-with-tsc.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs-extra';
-import * as path from 'node:path';
-import * as process from 'node:process';
+import * as path from 'path';
+import * as process from 'process';
 import * as ts from 'typescript';
 
 import type { Context } from '.';

packages/@jsii/benchmarks/lib/suite/aws-cdk-lib/index.ts

@@ -1,7 +1,7 @@
+import * as cp from 'child_process';
 import * as fs from 'fs-extra';
-import * as cp from 'node:child_process';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as os from 'os';
+import * as path from 'path';
 
 import { cdkTag, cdk } from '../../constants';
 import { inDirectory, streamUntar } from '../../util';

packages/@jsii/benchmarks/scripts/snapshot-package.ts

@@ -1,8 +1,8 @@
+import * as cp from 'child_process';
 import * as fs from 'fs-extra';
 import * as glob from 'glob';
-import * as cp from 'node:child_process';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as os from 'os';
+import * as path from 'path';
 import * as tar from 'tar';
 import * as ts from 'typescript';
 

packages/@jsii/check-node/src/constants.ts

@@ -1,4 +1,4 @@
-import * as process from 'node:process';
+import * as process from 'process';
 import { Range, SemVer } from 'semver';
 
 const ONE_DAY_IN_MILLISECONDS = 86_400_000;

packages/@jsii/check-node/src/index.ts

@@ -1,6 +1,6 @@
 import { Chalk, bgYellow, bgYellowBright, bgRed } from 'chalk';
-import { error } from 'node:console';
-import { version } from 'node:process';
+import { error } from 'console';
+import { version } from 'process';
 
 import { NodeRelease } from './constants';
 

packages/@jsii/integ-test/test/build-cdk.test.ts

@@ -1,8 +1,8 @@
 import { Octokit } from '@octokit/rest';
 import * as dotenv from 'dotenv';
 import { mkdtemp, readdir, remove } from 'fs-extra';
-import { tmpdir } from 'node:os';
-import * as path from 'node:path';
+import { tmpdir } from 'os';
+import * as path from 'path';
 
 import {
   downloadReleaseAsset,

packages/@jsii/integ-test/utils/index.ts

@@ -1,7 +1,7 @@
-import * as cp from 'node:child_process';
-import { IncomingMessage } from 'node:http';
-import * as https from 'node:https';
-import { Readable } from 'node:stream';
+import * as cp from 'child_process';
+import { IncomingMessage } from 'http';
+import * as https from 'https';
+import { Readable } from 'stream';
 import { extract } from 'tar';
 
 /**

packages/@jsii/kernel/src/kernel.test.ts

@@ -1,9 +1,9 @@
+import * as childProcess from 'child_process';
 import * as fs from 'fs-extra';
-import * as childProcess from 'node:child_process';
-import * as os from 'node:os';
-import { join } from 'node:path';
-import * as path from 'node:path';
-import * as vm from 'node:vm';
+import * as os from 'os';
+import { join } from 'path';
+import * as path from 'path';
+import * as vm from 'vm';
 
 import * as api from './api';
 import {

packages/@jsii/kernel/src/kernel.ts

@@ -1,11 +1,11 @@
 import * as spec from '@jsii/spec';
 import { loadAssemblyFromPath } from '@jsii/spec';
+import * as cp from 'child_process';
 import * as fs from 'fs-extra';
-import * as cp from 'node:child_process';
-import * as os from 'node:os';
-import * as path from 'node:path';
-import * as vm from 'node:vm';
+import * as os from 'os';
+import * as path from 'path';
 import * as tar from 'tar';
+import * as vm from 'vm';
 
 import * as api from './api';
 import { TOKEN_REF } from './api';
@@ -49,7 +49,7 @@ export class Kernel {
     // I wonder if webpack has some pragma that allows opting-out at certain points
     // in the code.
     // eslint-disable-next-line @typescript-eslint/no-require-imports,@typescript-eslint/no-var-requires
-    const moduleLoad = require('node:module').Module._load;
+    const moduleLoad = require('module').Module._load;
     const nodeRequire = (p: string) => moduleLoad(p, module, false);
 
     this.sandbox = vm.createContext({

packages/@jsii/kernel/src/on-exit.ts

@@ -1,5 +1,5 @@
 import * as fs from 'fs-extra';
-import * as process from 'node:process';
+import * as process from 'process';
 
 const removeSyncPaths = new Array<string>();
 

packages/@jsii/kernel/src/serialization.ts

@@ -27,8 +27,8 @@
  */
 
 import * as spec from '@jsii/spec';
-import * as assert from 'node:assert';
-import { inspect } from 'node:util';
+import * as assert from 'assert';
+import { inspect } from 'util';
 
 import {
   isObjRef,

packages/@jsii/runtime/bin/jsii-runtime.ts

@@ -1,10 +1,10 @@
 import '@jsii/check-node/run';
 
-import { spawn } from 'node:child_process';
-import { error } from 'node:console';
-import { constants as os } from 'node:os';
-import { resolve } from 'node:path';
-import { Duplex } from 'node:stream';
+import { spawn } from 'child_process';
+import { error } from 'console';
+import { constants as os } from 'os';
+import { resolve } from 'path';
+import { Duplex } from 'stream';
 
 // Spawn another node process, with the following file descriptor setup:
 // - No STDIN will be provided

packages/@jsii/runtime/lib/host.ts

@@ -1,5 +1,5 @@
 import { api, Kernel } from '@jsii/kernel';
-import { EventEmitter } from 'node:events';
+import { EventEmitter } from 'events';
 
 import { Input, IInputOutput } from './in-out';
 

packages/@jsii/runtime/lib/sync-stdio.ts

@@ -1,4 +1,4 @@
-import * as fs from 'node:fs';
+import * as fs from 'fs';
 
 const INPUT_BUFFER_SIZE = 1_048_576; // 1MiB (aka: 1024 * 1024), not related to max line length
 

packages/@jsii/runtime/test/kernel-host.test.ts

@@ -1,9 +1,9 @@
 import { api } from '@jsii/kernel';
 import * as spec from '@jsii/spec';
 import { loadAssemblyFromPath } from '@jsii/spec';
-import * as child from 'node:child_process';
-import * as fs from 'node:fs';
-import * as path from 'node:path';
+import * as child from 'child_process';
+import * as fs from 'fs';
+import * as path from 'path';
 
 import { KernelHost, IInputOutput, Input, Output } from '../lib';
 

packages/@jsii/runtime/test/playback.test.ts

@@ -1,7 +1,7 @@
-import * as child from 'node:child_process';
-import * as fs from 'node:fs';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as child from 'child_process';
+import * as fs from 'fs';
+import * as os from 'os';
+import * as path from 'path';
 
 import { IInputOutput, Input, KernelHost, Output } from '../lib';
 

packages/@jsii/spec/src/assembly-utils.test.ts

@@ -1,7 +1,7 @@
 import * as fs from 'fs-extra';
-import * as os from 'node:os';
-import * as path from 'node:path';
-import * as zlib from 'node:zlib';
+import * as os from 'os';
+import * as path from 'path';
+import * as zlib from 'zlib';
 
 import {
   SPEC_FILE_NAME,

packages/@jsii/spec/src/assembly-utils.ts

@@ -1,6 +1,6 @@
-import * as fs from 'node:fs';
-import * as path from 'node:path';
-import * as zlib from 'node:zlib';
+import * as fs from 'fs';
+import * as path from 'path';
+import * as zlib from 'zlib';
 
 import {
   Assembly,

packages/@jsii/spec/src/validate-assembly.test.ts

@@ -1,5 +1,5 @@
-import { readFileSync, readdirSync } from 'node:fs';
-import { resolve } from 'node:path';
+import { readFileSync, readdirSync } from 'fs';
+import { resolve } from 'path';
 
 import { validateAssembly } from './validate-assembly';
 

packages/codemaker/src/codemaker.test.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs-extra';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as os from 'os';
+import * as path from 'path';
 
 import { CodeMaker } from './codemaker';
 

packages/codemaker/src/codemaker.ts

@@ -1,4 +1,4 @@
-import * as util from 'node:util';
+import * as util from 'util';
 
 import * as caseutils from './case-utils';
 import FileBuffer from './filebuff';

packages/codemaker/src/filebuff.test.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs-extra';
-import * as os from 'node:os';
-import * as path from 'node:path';
+import * as os from 'os';
+import * as path from 'path';
 
 import FileBuffer from './filebuff';
 

packages/codemaker/src/filebuff.ts

@@ -1,4 +1,4 @@
-import * as path from 'node:path';
+import * as path from 'path';
 
 /**
  * Buffers the text of a file for later saving.

packages/jsii-calc/lib/cdk16625/index.ts

@@ -1,4 +1,4 @@
-import * as assert from 'node:assert';
+import * as assert from 'assert';
 
 import { IRandomNumberGenerator } from '../calculator';
 import { UnimportedSubmoduleType } from './donotimport';

packages/jsii-calc/lib/compliance.ts

@@ -8,11 +8,11 @@ import {
   StructWithOnlyOptionals,
   NumericValue,
 } from '@scope/jsii-calc-lib';
-import * as crypto from 'node:crypto';
-import * as fs from 'node:fs';
-import * as os from 'node:os';
-import * as path from 'node:path';
-import { promisify } from 'node:util';
+import * as crypto from 'crypto';
+import * as fs from 'fs';
+import * as os from 'os';
+import * as path from 'path';
+import { promisify } from 'util';
 
 import {
   IFriendlyRandomGenerator,

packages/jsii-calc/test/test.calc.ts

@@ -1,5 +1,5 @@
 import * as calcLib from '@scope/jsii-calc-lib';
-import * as assert from 'node:assert';
+import * as assert from 'assert';
 
 import {
   Add,

packages/jsii-calc/test/test.transitive.ts

@@ -2,9 +2,9 @@
 // take a direct dependency on @scope/jsii-calc-base-of-base, which is intended
 // to only be used as a transitive dependency through @scope/jsii-calc-base.
 
-import * as assert from 'node:assert';
-import { readFileSync } from 'node:fs';
-import { join } from 'node:path';
+import * as assert from 'assert';
+import { readFileSync } from 'fs';
+import { join } from 'path';
 
 const pkgjsonPath = join(__dirname, '..', 'package.json');
 const pkgjson = JSON.parse(readFileSync(pkgjsonPath, 'utf-8'));

packages/jsii-config/bin/jsii-config.ts

@@ -1,7 +1,7 @@
 import '@jsii/check-node/run';
 
-import { writeFile } from 'node:fs';
-import { promisify } from 'node:util';
+import { writeFile } from 'fs';
+import { promisify } from 'util';
 import * as yargs from 'yargs';
 
 import jsiiConfig from '../lib';

packages/jsii-config/lib/util.ts

@@ -1,4 +1,4 @@
-import { readFile } from 'node:fs';
+import { readFile } from 'fs';
 
 /*
  * Look for existing nested values in config, return undefined if not found

packages/jsii-config/test/index.test.ts

@@ -1,5 +1,5 @@
+import * as fs from 'fs';
 import * as inquirer from 'inquirer';
-import * as fs from 'node:fs';
 
 import jsiiConfig from '../lib';
 import { packageJsonObject, findQuestions, findQuestion } from './util';

packages/jsii-diff/lib/util.ts

@@ -1,9 +1,9 @@
+import * as childProcess from 'child_process';
 import * as fs from 'fs-extra';
 import * as log4js from 'log4js';
-import * as childProcess from 'node:child_process';
-import * as os from 'node:os';
-import * as path from 'node:path';
-import * as util from 'node:util';
+import * as os from 'os';
+import * as path from 'path';
+import * as util from 'util';
 
 const LOG = log4js.getLogger('jsii-diff');
 

packages/jsii-pacmak/lib/builder.ts

@@ -1,5 +1,5 @@
 import { Rosetta } from 'jsii-rosetta';
-import * as path from 'node:path';
+import * as path from 'path';
 
 import * as logging from './logging';
 import { JsiiModule } from './packaging';

packages/jsii-pacmak/lib/dependency-graph.ts

@@ -1,5 +1,5 @@
 import * as fs from 'fs-extra';
-import { join } from 'node:path';
+import { join } from 'path';
 
 import * as util from './util';