Skip to content

end_segment should not break when context_missing is LOG_ERROR #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaysonsantos opened this issue Sep 17, 2018 · 2 comments
Closed
Labels

Comments

@jaysonsantos
Copy link
Contributor

Right now, calls to end_segment will break when context_missing='LOG_ERROR', should that happen?

>>> xray_recorder.end_segment()
cannot find the current segment/subsegment, please make sure you have a segment open
No segment to end
cannot find the current segment/subsegment, please make sure you have a segment open
Traceback (most recent call last):
...
  File ".../aws-xray-sdk/aws_xray_sdk/core/recorder.py", line 229, in end_segment
    if self.current_segment().ready_to_send():
AttributeError: 'NoneType' object has no attribute 'ready_to_send'
@haotianw465
Copy link
Contributor

Thank you for reporting this issue. This is a bug and we will work on a fix soon.

@haotianw465
Copy link
Contributor

The issue is fixed in 2.2.0 https://pypi.org/project/aws-xray-sdk/. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants