Skip to content

Add SNS Service "Publish" operation to the aws_para_whitelist #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tankanow opened this issue Aug 31, 2018 · 2 comments
Closed

Add SNS Service "Publish" operation to the aws_para_whitelist #84

Tankanow opened this issue Aug 31, 2018 · 2 comments

Comments

@Tankanow
Copy link
Contributor

Currently the SNS publish operation shows up with a minimum set of metadata:

"aws": {
    "operation": "Publish",
    "region": "us-east-1",
    "request_id": "a939cee1-7c48-5675-b385-9ae2206dc121"
}

This should include at least the known internal AWS resources like TopicArn or TargetArn and maybe even the PhoneNumber.

@Tankanow
Copy link
Contributor Author

I will happily work on this if it's not on the roadmap.

@haotianw465
Copy link
Contributor

Hi, PhoneNumber is relatively sensitive and recording it by default is probably not a good idea. TopicArn on the other hand would be a vey useful information. Feel free to add it to the whitelist by submitting a PR and some unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants