Skip to content

subsegment name special characters #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thehesiod opened this issue Feb 14, 2018 · 2 comments · Fixed by #19
Closed

subsegment name special characters #20

thehesiod opened this issue Feb 14, 2018 · 2 comments · Fixed by #19

Comments

@thehesiod
Copy link
Contributor

thehesiod commented Feb 14, 2018

currently the following is allowed: string.ascii_letters + string.digits + '_.:/%&#=+\-@ ' per entity.py. However in the requests module (and httplib module I'm proposing based on it) it uses the url, which can include a ? character which yields a lot of warnings. Was the intention that everything after '?' would be stripped off? If so the requests module isn't doing this either. Could either do simple string clipping or use something like yarl

@haotianw465
Copy link
Contributor

Query string with "?" should not be part of a subsegment name. This is a bug. We will looking into a fix. A PR is also welcome.

@thehesiod
Copy link
Contributor Author

Ok cool, I'll add it to my httplib PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants