Poller threads block main thread from exiting bug #134

* Set poller threads as daemon threads so they dont block the main thread on exit.

Author: chanchiem

aws_xray_sdk/core/sampling/rule_poller.py

@@ -19,7 +19,9 @@ def __init__(self, cache, connector):
         self._connector = connector
 
     def start(self):
-        threading.Thread(target=self._worker).start()
+        poller_thread = threading.Thread(target=self._worker)
+        poller_thread.daemon = True
+        poller_thread.start()
 
     def _worker(self):
         frequency = 1

aws_xray_sdk/core/sampling/target_poller.py

@@ -20,7 +20,9 @@ def __init__(self, cache, rule_poller, connector):
         self._interval = 10 # default 10 seconds interval on sampling targets fetch
 
     def start(self):
-        threading.Thread(target=self._worker).start()
+        poller_thread = threading.Thread(target=self._worker)
+        poller_thread.daemon = True
+        poller_thread.start()
 
     def _worker(self):
         while True: