Add glob match to httplib ignore hostname.

Author: jonathangreen

aws_xray_sdk/ext/httplib/patch.py

@@ -1,7 +1,7 @@
 from collections import namedtuple
 import sys
 import wrapt
-
+import fnmatch
 import urllib3.connection
 
 from aws_xray_sdk.core import xray_recorder
@@ -106,7 +106,7 @@ def _ignore_request(subclass, hostname, url):
     global _XRAY_IGNORE
     for rule in _XRAY_IGNORE:
         subclass_match = subclass == rule.subclass if rule.subclass is not None else True
-        host_match = hostname == rule.hostname if rule.hostname is not None else True
+        host_match = fnmatch.fnmatch(hostname, rule.hostname) if rule.hostname is not None else True
         url_match = url in rule.urls if rule.urls is not None else True
         if url_match and host_match and subclass_match:
             return True

tests/ext/httplib/test_httplib.py

@@ -163,6 +163,16 @@ def test_ignore_hostname():
     reset_ignored()
 
 
+def test_ignore_hostname_glob():
+    from aws_xray_sdk.ext.httplib import add_ignored, reset_ignored
+    path = '/status/200'
+    url = 'https://{}{}'.format(BASE_URL, path)
+    add_ignored(hostname='http*.org')
+    _do_req(url, use_https=True)
+    assert len(xray_recorder.current_segment().subsegments) == 0
+    reset_ignored()
+
+
 def test_ignore_subclass():
     class TestClass(httplib.HTTPSConnection):
         pass