Skip to content

Commit b75ecaa

Browse files
committed
added checking false only conditions
1 parent 109d375 commit b75ecaa

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

aws_xray_sdk/core/models/dummy_entities.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ class DummySegment(Segment):
1717

1818
def __init__(self, name='dummy'):
1919
no_op_id = os.getenv('AWS_XRAY_NOOP_ID')
20-
if not no_op_id or no_op_id.lower() == 'true':
21-
super(DummySegment, self).__init__(name=name, traceid=NoOpTraceId().to_id(), entityid='0000000000000000')
22-
else:
20+
if no_op_id and no_op_id.lower() == 'false':
2321
super(DummySegment, self).__init__(name=name, traceid=TraceId().to_id())
22+
else:
23+
super(DummySegment, self).__init__(name=name, traceid=NoOpTraceId().to_id(), entityid='0000000000000000')
2424
self.sampled = False
2525

2626
def set_aws(self, aws_meta):
@@ -89,7 +89,9 @@ class DummySubsegment(Subsegment):
8989
def __init__(self, segment, name='dummy'):
9090
super(DummySubsegment, self).__init__(name, 'dummy', segment)
9191
no_op_id = os.getenv('AWS_XRAY_NOOP_ID')
92-
if not no_op_id or no_op_id.lower() == 'true':
92+
if no_op_id and no_op_id.lower() == 'false':
93+
super(Subsegment, self).__init__(name)
94+
else:
9395
super(Subsegment, self).__init__(name, entity_id='0000000000000000')
9496
self.sampled = False
9597

0 commit comments

Comments
 (0)