Fix http.URL field segment for Aiohttp extension (#37)

* Fix http.URL field segment for Aiohttp extension

* CHANGELOG

Author: pfreixes

CHANGELOG.rst

@@ -6,6 +6,8 @@ unreleased
 ==========
 * feature: Use the official middleware pattern for Aiohttp ext. `PR29 <https://github.com/aws/aws-xray-sdk-python/pull/29>`_.
 * bugfix: SQLAlcemy plugin would cause warning messages with some db connection strings that contained invalid characters for a segment/subsegment name.
+* bugfix: Aiohttp middleware serialized URL values incorrectly `PR37 <https://github.com/aws/aws-xray-sdk-python/pull/37>`_
+
 0.96
 ====
 * feature: Add support for SQLAlchemy and Flask-SQLAlcemy. `PR14 <https://github.com/aws/aws-xray-sdk-python/pull/14>`_.

aws_xray_sdk/ext/aiohttp/middleware.py

@@ -36,7 +36,7 @@ async def middleware(request, handler):
     )
 
     # Store request metadata in the current segment
-    segment.put_http_meta(http.URL, request.url)
+    segment.put_http_meta(http.URL, str(request.url))
     segment.put_http_meta(http.METHOD, request.method)
 
     if 'User-Agent' in request.headers:

tests/ext/aiohttp/test_aiohttp.py

@@ -119,9 +119,7 @@ async def test_ok(test_client, loop, recorder):
     response = segment.http['response']
 
     assert request['method'] == 'GET'
-    assert str(request['url']).startswith('http://127.0.0.1')
-    assert request['url'].host == '127.0.0.1'
-    assert request['url'].path == '/'
+    assert request['url'] == 'http://127.0.0.1:{port}/'.format(port=client.port)
     assert response['status'] == 200
 
 
@@ -145,8 +143,7 @@ async def test_error(test_client, loop, recorder):
     request = segment.http['request']
     response = segment.http['response']
     assert request['method'] == 'GET'
-    assert request['url'].host == '127.0.0.1'
-    assert request['url'].path == '/error'
+    assert request['url'] == 'http://127.0.0.1:{port}/error'.format(port=client.port)
     assert request['client_ip'] == '127.0.0.1'
     assert response['status'] == 404
 
@@ -172,8 +169,7 @@ async def test_exception(test_client, loop, recorder):
     response = segment.http['response']
     exception = segment.cause['exceptions'][0]
     assert request['method'] == 'GET'
-    assert request['url'].host == '127.0.0.1'
-    assert request['url'].path == '/exception'
+    assert request['url'] == 'http://127.0.0.1:{port}/exception'.format(port=client.port)
     assert request['client_ip'] == '127.0.0.1'
     assert response['status'] == 500
     assert exception.type == 'KeyError'