Skip to content

Commit 672062f

Browse files
authored
Added proper TraceID in dummy segments (#223)
* Added proper TraceID in dummy segments * Added test case to check valid TraceID
1 parent 2d12c83 commit 672062f

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

aws_xray_sdk/core/models/dummy_entities.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
from .traceid import TraceId
12
from .segment import Segment
23
from .subsegment import Subsegment
34

@@ -13,7 +14,7 @@ class DummySegment(Segment):
1314
"""
1415
def __init__(self, name='dummy'):
1516

16-
super(DummySegment, self).__init__(name=name, traceid='dummy')
17+
super(DummySegment, self).__init__(name=name, traceid=TraceId().to_id())
1718
self.sampled = False
1819

1920
def set_aws(self, aws_meta):

tests/test_dummy_entites.py

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33

44

55
def test_not_sampled():
6-
76
segment = DummySegment()
87
subsegment = DummySubsegment(segment)
98

@@ -12,7 +11,6 @@ def test_not_sampled():
1211

1312

1413
def test_no_ops():
15-
1614
segment = DummySegment()
1715
segment.put_metadata('key', 'value')
1816
segment.put_annotation('key', 'value')
@@ -63,3 +61,12 @@ def test_invalid_entity_name():
6361

6462
assert segment.name == 'DummySegment Test'
6563
assert subsegment.name == 'DummySubsegment'
64+
65+
66+
def test_dummy_segment_trace_id():
67+
segment = DummySegment()
68+
69+
assert segment.trace_id != 'dummy'
70+
assert '-' in segment.trace_id
71+
# checking version of trace id
72+
assert segment.trace_id[:1] == '1'

0 commit comments

Comments
 (0)