fix(util): update ini parsing (#4125)

* fix(util): update ini parsing

* fix(util): use indexOf instead of split

* fix(util): require non-empty for ini parse

* fix(util): update section parse to match v3

Author: kuhe

lib/util.js

@@ -215,20 +215,28 @@ var util = {
     parse: function string(ini) {
       var currentSection, map = {};
       util.arrayEach(ini.split(/\r?\n/), function(line) {
-        line = line.split(/(^|\s)[;#]/)[0]; // remove comments
-        var section = line.match(/^\s*\[([^\[\]]+)\]\s*$/);
-        if (section) {
-          currentSection = section[1];
+        line = line.split(/(^|\s)[;#]/)[0].trim(); // remove comments and trim
+        var isSection = line[0] === '[' && line[line.length - 1] === ']';
+        if (isSection) {
+          currentSection = line.substring(1, line.length - 1);
           if (currentSection === '__proto__' || currentSection.split(/\s/)[1] === '__proto__') {
             throw util.error(
               new Error('Cannot load profile name \'' + currentSection + '\' from shared ini file.')
             );
           }
         } else if (currentSection) {
-          var item = line.match(/^\s*(.+?)\s*=\s*(.+?)\s*$/);
-          if (item) {
+          var indexOfEqualsSign = line.indexOf('=');
+          var start = 0;
+          var end = line.length - 1;
+          var isAssignment =
+            indexOfEqualsSign !== -1 && indexOfEqualsSign !== start && indexOfEqualsSign !== end;
+
+          if (isAssignment) {
+            var name = line.substring(0, indexOfEqualsSign).trim();
+            var value = line.substring(indexOfEqualsSign + 1).trim();
+
             map[currentSection] = map[currentSection] || {};
-            map[currentSection][item[1]] = item[2];
+            map[currentSection][name] = value;
           }
         }
       });