Skip to content

feat(middleware-bucket-endpoint): generate endpoint from Access Point ARN #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2020

Conversation

AllanZhengYP
Copy link
Contributor

Description of changes:
With this change, users can supply a valid Access Point ARN to the Bucket parameter in S3 operations. SDK will make request to an Access Point endpoint instead of the normal bucket endpoint.

Users can also call the bucketHostname() directly without S3 client to generate the request hostname from the given input.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@c18bfe4). Click here to learn what that means.
The diff coverage is 97.43%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1441   +/-   ##
=========================================
  Coverage          ?   79.79%           
=========================================
  Files             ?      300           
  Lines             ?    11478           
  Branches          ?     2466           
=========================================
  Hits              ?     9159           
  Misses            ?     2319           
  Partials          ?        0           
Impacted Files Coverage Δ
...s/middleware-bucket-endpoint/src/bucketHostname.ts 95.65% <94.73%> (ø)
...dleware-bucket-endpoint/src/bucketHostnameUtils.ts 98.33% <98.33%> (ø)
...re-bucket-endpoint/src/bucketEndpointMiddleware.ts 91.66% <100.00%> (ø)
...s/middleware-bucket-endpoint/src/configurations.ts 100.00% <100.00%> (ø)
...er-cognito-identity/src/fromCognitoIdentityPool.ts 100.00% <0.00%> (ø)
...ges/eventstream-marshaller/src/HeaderMarshaller.ts 100.00% <0.00%> (ø)
packages/middleware-stack/src/MiddlewareStack.ts 98.38% <0.00%> (ø)
...tests/aws-restxml/commands/XmlAttributesCommand.ts 100.00% <0.00%> (ø)
...ests/aws-restxml/commands/XmlMapsXmlNameCommand.ts 100.00% <0.00%> (ø)
packages/url-parser-browser/src/index.ts 100.00% <0.00%> (ø)
... and 294 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18bfe4...d9ffa0f. Read the comment docs.

@AllanZhengYP AllanZhengYP changed the title [WIP]feat(middleware-bucket-endpoint): generate endpoint from Access Point ARN feat(middleware-bucket-endpoint): generate endpoint from Access Point ARN Aug 17, 2020
@AllanZhengYP AllanZhengYP marked this pull request as ready for review August 17, 2020 20:22
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, some minor comments and nits

@AllanZhengYP AllanZhengYP requested a review from trivikr August 18, 2020 21:40
@AllanZhengYP AllanZhengYP requested a review from trivikr August 19, 2020 16:13
@AllanZhengYP AllanZhengYP merged commit b5da159 into aws:master Aug 19, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants