-
Notifications
You must be signed in to change notification settings - Fork 616
feat(middleware-bucket-endpoint): generate endpoint from Access Point ARN #1441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6bec783
to
4fdd70a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1441 +/- ##
=========================================
Coverage ? 79.79%
=========================================
Files ? 300
Lines ? 11478
Branches ? 2466
=========================================
Hits ? 9159
Misses ? 2319
Partials ? 0
Continue to review full report at Codecov.
|
0df9672
to
62ffeec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, some minor comments and nits
Co-authored-by: Trivikram Kamat <[email protected]>
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Description of changes:
With this change, users can supply a valid Access Point ARN to the
Bucket
parameter inS3
operations. SDK will make request to an Access Point endpoint instead of the normal bucket endpoint.Users can also call the
bucketHostname()
directly without S3 client to generate the request hostname from the given input.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.