Skip to content

feat: add retry quotas to StandardRetryStrategy #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 15, 2020
Merged

feat: add retry quotas to StandardRetryStrategy #1258

merged 9 commits into from
Jun 15, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 10, 2020

Issue #, if available:
Internal tracking issue JS-1812

Description of changes:
add retry quotas to StandardRetryStrategy

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr mentioned this pull request Jun 10, 2020
Closed
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation

This comment has been minimized.

Sign in to view
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 01ad868
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr requested a review from AllanZhengYP June 12, 2020 17:16
@trivikr trivikr mentioned this pull request Jun 12, 2020
Closed
AllanZhengYP
AllanZhengYP reviewed Jun 15, 2020
View reviewed changes
@trivikr trivikr requested a review from AllanZhengYP June 15, 2020 20:53
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 8a1c222
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AllanZhengYP
AllanZhengYP approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. ⛴

@trivikr trivikr merged commit 33364cb into aws:master Jun 15, 2020
@trivikr trivikr deleted the retry-quotas-dev branch June 16, 2020 19:25
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

2 similar comments
@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock
Copy link

lock bot commented Jun 24, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trivikr @aws-sdk-js-automation @AllanZhengYP