Skip to content

Commit e7dce39

Browse files
authored
fix(middleware-user-agent): add middleware to final step of build (#1833)
previously the middleware was added relative(before) signing middleware. It will through for the requests not requiring singing. So change it to absolute position.
1 parent 0711503 commit e7dce39

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

packages/middleware-user-agent/src/user-agent-middleware.ts

+11-10
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
import { HttpRequest } from "@aws-sdk/protocol-http";
22
import {
3-
FinalizeHandler,
4-
FinalizeHandlerArguments,
5-
FinalizeHandlerOutput,
3+
AbsoluteLocation,
4+
BuildHandler,
5+
BuildHandlerArguments,
6+
BuildHandlerOptions,
7+
BuildHandlerOutput,
68
HandlerExecutionContext,
79
MetadataBearer,
810
Pluggable,
9-
RelativeMiddlewareOptions,
1011
UserAgentPair,
1112
} from "@aws-sdk/types";
1213

@@ -26,9 +27,9 @@ import { SPACE, UA_ESCAPE_REGEX, USER_AGENT, X_AMZ_USER_AGENT } from "./constant
2627
* agent.
2728
*/
2829
export const userAgentMiddleware = (options: UserAgentResolvedConfig) => <Output extends MetadataBearer>(
29-
next: FinalizeHandler<any, any>,
30+
next: BuildHandler<any, any>,
3031
context: HandlerExecutionContext
31-
): FinalizeHandler<any, any> => async (args: FinalizeHandlerArguments<any>): Promise<FinalizeHandlerOutput<Output>> => {
32+
): BuildHandler<any, any> => async (args: BuildHandlerArguments<any>): Promise<BuildHandlerOutput<Output>> => {
3233
const { request } = args;
3334
if (!HttpRequest.isInstance(request)) return next(args);
3435
const { headers } = request;
@@ -70,15 +71,15 @@ const escapeUserAgent = ([name, version]: UserAgentPair): string => {
7071
.join("/");
7172
};
7273

73-
export const getUserAgentMiddlewareOptions: RelativeMiddlewareOptions = {
74+
export const getUserAgentMiddlewareOptions: BuildHandlerOptions & AbsoluteLocation = {
7475
name: "getUserAgentMiddleware",
75-
relation: "before",
76-
toMiddleware: "awsAuthMiddleware",
76+
step: "build",
77+
priority: "low",
7778
tags: ["SET_USER_AGENT", "USER_AGENT"],
7879
};
7980

8081
export const getUserAgentPlugin = (config: UserAgentResolvedConfig): Pluggable<any, any> => ({
8182
applyToStack: (clientStack) => {
82-
clientStack.addRelativeTo(userAgentMiddleware(config), getUserAgentMiddlewareOptions);
83+
clientStack.add(userAgentMiddleware(config), getUserAgentMiddlewareOptions);
8384
},
8485
});

0 commit comments

Comments
 (0)