Skip to content

Commit bee52db

Browse files
committed
chore(middleware-serde): remove logging of input from deserMiddleware
1 parent 4572120 commit bee52db

File tree

2 files changed

+8
-44
lines changed

2 files changed

+8
-44
lines changed

packages/middleware-serde/src/deserializerMiddleware.spec.ts

Lines changed: 8 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import { Logger } from "@aws-sdk/types";
2-
31
import { deserializerMiddleware } from "./deserializerMiddleware";
42

53
describe("deserializerMiddleware", () => {
@@ -51,38 +49,17 @@ describe("deserializerMiddleware", () => {
5149
});
5250

5351
afterEach(() => {
54-
expect(mockNext).toHaveBeenCalledTimes(1);
55-
expect(mockNext).toHaveBeenCalledWith(mockArgs);
56-
expect(mockDeserializer).toHaveBeenCalledTimes(1);
57-
expect(mockDeserializer).toHaveBeenCalledWith(mockNextResponse.response, mockOptions);
5852
jest.clearAllMocks();
5953
});
6054

61-
it("returns without logging if context.logger is not defined", async () => {
62-
const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, {})(mockArgs);
63-
expect(response).toStrictEqual(mockResponse);
64-
});
65-
66-
it("returns without logging if context.logger doesn't have debug/info function", async () => {
67-
const logger = {} as Logger;
68-
const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, { logger })(mockArgs);
69-
expect(response).toStrictEqual(mockResponse);
70-
});
71-
72-
it("logs output if context.logger has info function", async () => {
73-
const logger = ({ info: jest.fn() } as unknown) as Logger;
55+
it("calls deserializer and populates response object", async () => {
56+
await expect(deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, {})(mockArgs)).resolves.toStrictEqual(
57+
mockResponse
58+
);
7459

75-
const outputFilterSensitiveLog = jest.fn().mockImplementationOnce((output) => output);
76-
const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, {
77-
logger,
78-
outputFilterSensitiveLog: outputFilterSensitiveLog,
79-
})(mockArgs);
80-
81-
const { $metadata, ...outputWithoutMetadata } = mockOutput;
82-
expect(response).toStrictEqual(mockResponse);
83-
expect(outputFilterSensitiveLog).toHaveBeenCalledTimes(1);
84-
expect(outputFilterSensitiveLog).toHaveBeenCalledWith(outputWithoutMetadata);
85-
expect(logger.info).toHaveBeenCalledTimes(1);
86-
expect(logger.info).toHaveBeenCalledWith({ output: outputWithoutMetadata });
60+
expect(mockNext).toHaveBeenCalledTimes(1);
61+
expect(mockNext).toHaveBeenCalledWith(mockArgs);
62+
expect(mockDeserializer).toHaveBeenCalledTimes(1);
63+
expect(mockDeserializer).toHaveBeenCalledWith(mockNextResponse.response, mockOptions);
8764
});
8865
});

packages/middleware-serde/src/deserializerMiddleware.ts

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,21 +16,8 @@ export const deserializerMiddleware = <Input extends object, Output extends obje
1616
): DeserializeHandler<Input, Output> => async (
1717
args: DeserializeHandlerArguments<Input>
1818
): Promise<DeserializeHandlerOutput<Output>> => {
19-
const { logger, outputFilterSensitiveLog } = context;
20-
2119
const { response } = await next(args);
22-
2320
const parsed = await deserializer(response, options);
24-
25-
// Log parsed after $metadata is removed in https://github.com/aws/aws-sdk-js-v3/issues/1490
26-
const { $metadata, ...outputWithoutMetadata } = parsed;
27-
28-
if (typeof logger?.info === "function") {
29-
logger.info({
30-
output: outputFilterSensitiveLog(outputWithoutMetadata),
31-
});
32-
}
33-
3421
return {
3522
response,
3623
output: parsed as Output,

0 commit comments

Comments
 (0)