chore(middleware-serde): remove logging of input from deserMiddleware

Author: trivikr

packages/middleware-serde/src/deserializerMiddleware.spec.ts

@@ -1,5 +1,3 @@
-import { Logger } from "@aws-sdk/types";
-
 import { deserializerMiddleware } from "./deserializerMiddleware";
 
 describe("deserializerMiddleware", () => {
@@ -51,38 +49,17 @@ describe("deserializerMiddleware", () => {
   });
 
   afterEach(() => {
-    expect(mockNext).toHaveBeenCalledTimes(1);
-    expect(mockNext).toHaveBeenCalledWith(mockArgs);
-    expect(mockDeserializer).toHaveBeenCalledTimes(1);
-    expect(mockDeserializer).toHaveBeenCalledWith(mockNextResponse.response, mockOptions);
     jest.clearAllMocks();
   });
 
-  it("returns without logging if context.logger is not defined", async () => {
-    const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, {})(mockArgs);
-    expect(response).toStrictEqual(mockResponse);
-  });
-
-  it("returns without logging if context.logger doesn't have debug/info function", async () => {
-    const logger = {} as Logger;
-    const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, { logger })(mockArgs);
-    expect(response).toStrictEqual(mockResponse);
-  });
-
-  it("logs output if context.logger has info function", async () => {
-    const logger = ({ info: jest.fn() } as unknown) as Logger;
+  it("calls deserializer and populates response object", async () => {
+    await expect(deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, {})(mockArgs)).resolves.toStrictEqual(
+      mockResponse
+    );
 
-    const outputFilterSensitiveLog = jest.fn().mockImplementationOnce((output) => output);
-    const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, {
-      logger,
-      outputFilterSensitiveLog: outputFilterSensitiveLog,
-    })(mockArgs);
-
-    const { $metadata, ...outputWithoutMetadata } = mockOutput;
-    expect(response).toStrictEqual(mockResponse);
-    expect(outputFilterSensitiveLog).toHaveBeenCalledTimes(1);
-    expect(outputFilterSensitiveLog).toHaveBeenCalledWith(outputWithoutMetadata);
-    expect(logger.info).toHaveBeenCalledTimes(1);
-    expect(logger.info).toHaveBeenCalledWith({ output: outputWithoutMetadata });
+    expect(mockNext).toHaveBeenCalledTimes(1);
+    expect(mockNext).toHaveBeenCalledWith(mockArgs);
+    expect(mockDeserializer).toHaveBeenCalledTimes(1);
+    expect(mockDeserializer).toHaveBeenCalledWith(mockNextResponse.response, mockOptions);
   });
 });

packages/middleware-serde/src/deserializerMiddleware.ts

@@ -16,21 +16,8 @@ export const deserializerMiddleware = <Input extends object, Output extends obje
 ): DeserializeHandler<Input, Output> => async (
   args: DeserializeHandlerArguments<Input>
 ): Promise<DeserializeHandlerOutput<Output>> => {
-  const { logger, outputFilterSensitiveLog } = context;
-
   const { response } = await next(args);
-
   const parsed = await deserializer(response, options);
-
-  // Log parsed after $metadata is removed in https://github.com/aws/aws-sdk-js-v3/issues/1490
-  const { $metadata, ...outputWithoutMetadata } = parsed;
-
-  if (typeof logger?.info === "function") {
-    logger.info({
-      output: outputFilterSensitiveLog(outputWithoutMetadata),
-    });
-  }
-
   return {
     response,
     output: parsed as Output,