Skip to content

Commit 7fd4d55

Browse files
authored
fix(lib-storage): use AbortController interface instead of class as type (#5843)
1 parent ba02fa1 commit 7fd4d55

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

Diff for: lib/lib-storage/src/Upload.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@ import {
1111
Tag,
1212
UploadPartCommand,
1313
} from "@aws-sdk/client-s3";
14-
import { AbortController, AbortSignal } from "@smithy/abort-controller";
14+
import { AbortController } from "@smithy/abort-controller";
1515
import {
1616
EndpointParameterInstructionsSupplier,
1717
getEndpointFromInstructions,
1818
toEndpointV1,
1919
} from "@smithy/middleware-endpoint";
2020
import { HttpRequest } from "@smithy/protocol-http";
2121
import { extendedEncodeURIComponent } from "@smithy/smithy-client";
22-
import { Endpoint } from "@smithy/types";
22+
import type { AbortController as IAbortController, AbortSignal as IAbortSignal, Endpoint } from "@smithy/types";
2323
import { EventEmitter } from "events";
2424

2525
import { byteLength } from "./bytelength";
@@ -54,7 +54,7 @@ export class Upload extends EventEmitter {
5454
private bytesUploadedSoFar: number;
5555

5656
// used in the upload.
57-
private abortController: AbortController;
57+
private abortController: IAbortController;
5858
private concurrentUploaders: Promise<void>[] = [];
5959
private createMultiPartPromise?: Promise<CreateMultipartUploadCommandOutput>;
6060

@@ -362,7 +362,7 @@ export class Upload extends EventEmitter {
362362
}
363363
}
364364

365-
private async __abortTimeout(abortSignal: AbortSignal): Promise<never> {
365+
private async __abortTimeout(abortSignal: IAbortSignal): Promise<never> {
366366
return new Promise((resolve, reject) => {
367367
abortSignal.onabort = () => {
368368
const abortError = new Error("Upload aborted.");

Diff for: lib/lib-storage/src/types.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { PutObjectCommandInput, S3Client, Tag } from "@aws-sdk/client-s3";
2-
import { AbortController } from "@smithy/abort-controller";
2+
import type { AbortController } from "@smithy/types";
33

44
export interface Progress {
55
loaded?: number;

0 commit comments

Comments
 (0)