Skip to content

Commit 751245a

Browse files
authored
fix(endpoint): join authScheme signingRegionSet values instead of taking first only (#4056)
1 parent e8d7c68 commit 751245a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/middleware-signing/src/middleware.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ export const awsAuthMiddleware =
2424

2525
// TODO(identityandauth): call authScheme resolver
2626
const authScheme: AuthScheme | undefined = context.endpointV2?.properties?.authSchemes?.[0];
27+
2728
const multiRegionOverride: string | undefined =
28-
authScheme?.name === "sigv4a" ? authScheme?.signingRegionSet?.[0] : undefined;
29+
authScheme?.name === "sigv4a" ? authScheme?.signingRegionSet?.join(",") : undefined;
2930

3031
const signer = await options.signer(authScheme);
3132

packages/types/src/auth.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,8 @@ export interface AuthScheme {
1515
*/
1616
signingRegion: string;
1717
/**
18-
* TODO usage?
18+
* @example ["*"]
19+
* @exammple ["us-west-2", "us-east-1"]
1920
*/
2021
signingRegionSet?: string[];
2122
/**

0 commit comments

Comments
 (0)