Skip to content

Commit 669a7de

Browse files
authored
chore(core): skip emitting warning for Node.js 14.x (#6044)
1 parent 306aafc commit 669a7de

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

packages/core/src/client/emitWarningIfUnsupportedVersion.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ describe("emitWarningIfUnsupportedVersion", () => {
1414
process.emitWarning = emitWarning;
1515
});
1616

17-
describe(`emits warning for Node.js <${supportedVersion}`, () => {
17+
describe.skip(`emits warning for Node.js <${supportedVersion}`, () => {
1818
const getPreviousMajorVersion = (major: number) => (major === 0 ? 0 : major - 1);
1919

2020
const getPreviousMinorVersion = ([major, minor]: [number, number]) =>

packages/core/src/client/emitWarningIfUnsupportedVersion.ts

+8-7
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,15 @@ let warningEmitted = false;
1212
export const emitWarningIfUnsupportedVersion = (version: string) => {
1313
if (version && !warningEmitted && parseInt(version.substring(1, version.indexOf("."))) < 16) {
1414
warningEmitted = true;
15-
process.emitWarning(
16-
`NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
17-
no longer support Node.js 14.x on May 1, 2024.
15+
// ToDo: Turn back warning for future Node.js version deprecation
16+
// process.emitWarning(
17+
// `NodeDeprecationWarning: The AWS SDK for JavaScript (v3) will
18+
// no longer support Node.js 14.x on May 1, 2024.
1819

19-
To continue receiving updates to AWS services, bug fixes, and security
20-
updates please upgrade to an active Node.js LTS version.
20+
// To continue receiving updates to AWS services, bug fixes, and security
21+
// updates please upgrade to an active Node.js LTS version.
2122

22-
More information can be found at: https://a.co/dzr2AJd`
23-
);
23+
// More information can be found at: https://a.co/dzr2AJd`
24+
// );
2425
}
2526
};

0 commit comments

Comments
 (0)