Skip to content

Commit 65ace72

Browse files
committed
fix(s3-request-presigner): address feedbacks
1 parent 30cfb43 commit 65ace72

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

packages/s3-request-presigner/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ JavaScript Example:
1515
```javascript
1616
const { getSignedUrl } = require("@aws-sdk/s3-request-presigner");
1717
const { S3Client, GetObjectCommand } = require("@aws-sdk/client-s3");
18-
const client = new S3Client(construcParams);
18+
const client = new S3Client(clientParams);
1919
const command = new GetObjectCommand(getObjectParams);
2020
const url = await getSignedUrl(client, command, { expiresIn: 3600 });
2121
```
@@ -25,7 +25,7 @@ ES6 Example
2525
```javascript
2626
import { getSignedUrl } from "@aws-sdk/s3-request-presigner";
2727
import { S3Client, GetObjectCommand } from "@aws-sdk/client-s3";
28-
const client = new S3Client(construcParams);
28+
const client = new S3Client(clientParams);
2929
const command = new GetObjectCommand(getObjectParams);
3030
const url = await getSignedUrl(client, command, { expiresIn: 3600 });
3131
```

packages/s3-request-presigner/src/getSignedUrl.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@ export const getSignedUrl = async <
5252
//@ts-ignore the output is faked, so it's not actually OutputType
5353
presigned = output.presigned;
5454
} finally {
55-
// client middleware stack should not be altered by this function
5655
client.middlewareStack.remove("presignInterceptMiddleware");
5756
}
5857

0 commit comments

Comments
 (0)