fix(property-provider): copy error properties to ProviderError in from() (#3440)

Author: trivikr

packages/property-provider/src/CredentialsProviderError.spec.ts

@@ -1,18 +1,18 @@
 import { CredentialsProviderError } from "./CredentialsProviderError";
+import { ProviderError } from "./ProviderError";
 
 describe(CredentialsProviderError.name, () => {
   it("should be named as CredentialsProviderError", () => {
     expect(new CredentialsProviderError("PANIC").name).toBe("CredentialsProviderError");
   });
 
-  describe("should be instanceof CredentialsProviderError", () => {
+  describe.each([Error, ProviderError, CredentialsProviderError])("should be instanceof %p", (classConstructor) => {
     it("when created using constructor", () => {
-      expect(new CredentialsProviderError("PANIC")).toBeInstanceOf(CredentialsProviderError);
+      expect(new CredentialsProviderError("PANIC")).toBeInstanceOf(classConstructor);
     });
 
     it("when created using from()", () => {
-      // ToDo: set instanceof to be CredentialsProviderError
-      expect(CredentialsProviderError.from(new Error("PANIC"))).toBeInstanceOf(Error);
+      expect(CredentialsProviderError.from(new Error("PANIC"))).toBeInstanceOf(classConstructor);
     });
   });
 });

packages/property-provider/src/ProviderError.spec.ts

@@ -13,14 +13,13 @@ describe(ProviderError.name, () => {
     expect(new ProviderError("PANIC", false).tryNextLink).toBe(false);
   });
 
-  describe("should be instanceof ProviderError", () => {
+  describe.each([Error, ProviderError])("should be instanceof %p", (classConstructor) => {
     it("when created using constructor", () => {
-      expect(new ProviderError("PANIC")).toBeInstanceOf(ProviderError);
+      expect(new ProviderError("PANIC")).toBeInstanceOf(classConstructor);
     });
 
     it("when created using from()", () => {
-      // ToDo: set instanceof to be CredentialsProviderError
-      expect(ProviderError.from(new Error("PANIC"))).toBeInstanceOf(Error);
+      expect(ProviderError.from(new Error("PANIC"))).toBeInstanceOf(classConstructor);
     });
   });
 

packages/property-provider/src/ProviderError.ts

@@ -13,12 +13,6 @@ export class ProviderError extends Error {
     super(message);
   }
   static from(error: Error, tryNextLink = true): ProviderError {
-    Object.defineProperty(error, "tryNextLink", {
-      value: tryNextLink,
-      configurable: false,
-      enumerable: false,
-      writable: false,
-    });
-    return error as ProviderError;
+    return Object.assign(new this(error.message, tryNextLink), error);
   }
 }