Skip to content

Commit 3f1b45d

Browse files
committed
chore: remove getSafeDataSource from XmlMemberDeserVisitor
1 parent bcfa99c commit 3f1b45d

File tree

1 file changed

+3
-25
lines changed

1 file changed

+3
-25
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlMemberDeserVisitor.java

Lines changed: 3 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -51,31 +51,9 @@ final class XmlMemberDeserVisitor extends DocumentMemberDeserVisitor {
5151
super(context, dataSource, defaultTimestampFormat);
5252
}
5353

54-
@Override
55-
public String stringShape(StringShape shape) {
56-
return getSafeDataSource();
57-
}
58-
59-
/**
60-
* Provides a data source safety mechanism to handle nodes that are
61-
* expected to have only a value but were loaded from a node with
62-
* a namespace.
63-
*
64-
* @return The node's value having handled a potential namespace.
65-
*/
66-
private String getSafeDataSource() {
67-
String dataSource = getDataSource();
68-
return "((" + dataSource + "['#text'] !== undefined) ? " + dataSource + "['#text'] : " + dataSource + ")";
69-
}
70-
71-
@Override
72-
public String blobShape(BlobShape shape) {
73-
return "context.base64Decoder(" + getSafeDataSource() + ")";
74-
}
75-
7654
@Override
7755
public String booleanShape(BooleanShape shape) {
78-
return getSafeDataSource() + " == 'true'";
56+
return getDataSource() + " == 'true'";
7957
}
8058

8159
@Override
@@ -99,7 +77,7 @@ public String longShape(LongShape shape) {
9977
}
10078

10179
private String deserializeInt() {
102-
return "parseInt(" + getSafeDataSource() + ")";
80+
return "parseInt(" + getDataSource() + ")";
10381
}
10482

10583
@Override
@@ -113,7 +91,7 @@ public String doubleShape(DoubleShape shape) {
11391
}
11492

11593
private String deserializeFloat() {
116-
return "parseFloat(" + getSafeDataSource() + ")";
94+
return "parseFloat(" + getDataSource() + ")";
11795
}
11896

11997
@Override

0 commit comments

Comments
 (0)