Skip to content

Commit 3179af2

Browse files
authored
test: fix type checks in e2e tests (#6075)
1 parent 74e4c14 commit 3179af2

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

packages/ec2-metadata-service/src/MetadataService.e2e.spec.ts

+6-6
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { fromInstanceMetadata } from "@aws-sdk/credential-providers";
33
import { MetadataService } from "./MetadataService";
44

55
describe("MetadataService E2E Tests", () => {
6-
let metadataService;
6+
let metadataService: any;
77
const provider = fromInstanceMetadata({ timeout: 1000, maxRetries: 0 });
8-
let metadataServiceAvailable;
8+
let metadataServiceAvailable: any;
99

1010
beforeAll(async () => {
1111
try {
@@ -35,7 +35,7 @@ describe("MetadataService E2E Tests", () => {
3535
if (!metadataServiceAvailable) {
3636
return;
3737
}
38-
const metadata = await metadataService.request("/latest/meta-data/", {});
38+
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
3939
expect(metadata).toBeDefined();
4040
expect(typeof metadata).toBe("string");
4141
const lines = metadata.split("\n").map((line) => line.trim());
@@ -49,7 +49,7 @@ describe("MetadataService E2E Tests", () => {
4949
return;
5050
}
5151
metadataService.disableFetchToken = true; // make request without token
52-
const metadata = await metadataService.request("/latest/meta-data/", {});
52+
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
5353
expect(metadata).toBeDefined();
5454
expect(typeof metadata).toBe("string");
5555
expect(metadata.length).toBeGreaterThan(0);
@@ -67,7 +67,7 @@ describe("MetadataService E2E Tests", () => {
6767
throw { name: "TimeoutError" }; // Simulating TimeoutError
6868
});
6969
// Attempt to fetch metadata, expecting IMDSv1 fallback (request without token)
70-
const metadata = await metadataService.request("/latest/meta-data/", {});
70+
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
7171
expect(metadata).toBeDefined();
7272
expect(typeof metadata).toBe("string");
7373
const lines = metadata.split("\n").map((line) => line.trim());
@@ -85,7 +85,7 @@ describe("MetadataService E2E Tests", () => {
8585
jest.spyOn(metadataService, "fetchMetadataToken").mockImplementationOnce(async () => {
8686
throw { statusCode: errorCode };
8787
});
88-
const metadata = await metadataService.request("/latest/meta-data/", {});
88+
const metadata = (await metadataService.request("/latest/meta-data/", {})) as string;
8989
expect(metadata).toBeDefined();
9090
expect(typeof metadata).toBe("string");
9191
const lines = metadata.split("\n").map((line) => line.trim());

packages/middleware-sdk-s3/src/s3-express/middleware-s3-express.e2e.spec.ts

+2
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,9 @@ async function createClientAndRecorder() {
239239
const commandName = context.commandName + s3ExpressSuffix;
240240
const input = args.input;
241241
const commandRecorder = (recorder.calls[commandName] = recorder.calls[commandName] ?? {});
242+
// @ts-expect-error Element implicitly has an 'any' type
242243
commandRecorder[input["Bucket"] ?? "-"] |= 0;
244+
// @ts-expect-error Element implicitly has an 'any' type
243245
commandRecorder[input["Bucket"] ?? "-"]++;
244246

245247
return continuation;

packages/s3-presigned-post/src/createPresignedPost.e2e.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ describe(createPresignedPost.name, () => {
8282
expect(precheck).toBeInstanceOf(NoSuchKey);
8383

8484
const submit: { statusCode: number } = await new Promise((resolve, reject) => {
85-
form.submit(url, (err, res) => {
85+
form.submit(url, (err: any, res: any) => {
8686
if (err) reject(err);
8787
resolve(res);
8888
});

0 commit comments

Comments
 (0)