Skip to content

Commit 2f1975d

Browse files
authored
fix(logger): disable logging of raw HTTP request/response (#1682)
1 parent 0964faf commit 2f1975d

File tree

4 files changed

+0
-32
lines changed

4 files changed

+0
-32
lines changed

packages/middleware-serde/src/deserializerMiddleware.spec.ts

-10
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,4 @@ describe("deserializerMiddleware", () => {
8585
expect(logger.info).toHaveBeenCalledTimes(1);
8686
expect(logger.info).toHaveBeenCalledWith({ output: outputWithoutMetadata });
8787
});
88-
89-
it("logs response if context.logger has debug function", async () => {
90-
const logger = ({ debug: jest.fn() } as unknown) as Logger;
91-
92-
const response = await deserializerMiddleware(mockOptions, mockDeserializer)(mockNext, { logger })(mockArgs);
93-
94-
expect(response).toStrictEqual(mockResponse);
95-
expect(logger.debug).toHaveBeenCalledTimes(1);
96-
expect(logger.debug).toHaveBeenCalledWith({ httpResponse: mockNextResponse.response });
97-
});
9888
});

packages/middleware-serde/src/deserializerMiddleware.ts

-6
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,6 @@ export const deserializerMiddleware = <Input extends object, Output extends obje
2020

2121
const { response } = await next(args);
2222

23-
if (typeof logger?.debug === "function") {
24-
logger.debug({
25-
httpResponse: response,
26-
});
27-
}
28-
2923
const parsed = await deserializer(response, options);
3024

3125
// Log parsed after $metadata is removed in https://github.com/aws/aws-sdk-js-v3/issues/1490

packages/middleware-serde/src/serializerMiddleware.spec.ts

-10
Original file line numberDiff line numberDiff line change
@@ -83,14 +83,4 @@ describe("serializerMiddleware", () => {
8383
expect(logger.info).toHaveBeenCalledTimes(1);
8484
expect(logger.info).toHaveBeenCalledWith({ input: mockArgs.input });
8585
});
86-
87-
it("logs request if context.logger has debug function", async () => {
88-
const logger = ({ debug: jest.fn() } as unknown) as Logger;
89-
90-
const response = await serializerMiddleware(mockOptions, mockSerializer)(mockNext, { logger })(mockArgs);
91-
92-
expect(response).toStrictEqual(mockReturn);
93-
expect(logger.debug).toHaveBeenCalledTimes(1);
94-
expect(logger.debug).toHaveBeenCalledWith({ httpRequest: mockRequest });
95-
});
9686
});

packages/middleware-serde/src/serializerMiddleware.ts

-6
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@ export const serializerMiddleware = <Input extends object, Output extends object
2727

2828
const request = await serializer(args.input, options);
2929

30-
if (typeof logger?.debug === "function") {
31-
logger.debug({
32-
httpRequest: request,
33-
});
34-
}
35-
3630
return next({
3731
...args,
3832
request,

0 commit comments

Comments
 (0)