Skip to content

Commit 22701ee

Browse files
authored
chore(scripts): use same version of devDeps across clients (#3245)
1 parent ad61024 commit 22701ee

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

Diff for: scripts/generate-clients/copy-to-clients.js

+14-10
Original file line numberDiff line numberDiff line change
@@ -36,16 +36,20 @@ const mergeManifest = (fromContent = {}, toContent = {}) => {
3636
for (const name of Object.keys(fromContent)) {
3737
if (fromContent[name].constructor.name === "Object") {
3838
if (name === "devDependencies") {
39-
// Remove devDeps defined in monorepo root
40-
const devDepsInRoot = [
41-
"@tsconfig/recommended",
42-
"concurrently",
43-
"downlevel-dts",
44-
"rimraf",
45-
"typedoc",
46-
"typescript",
47-
];
48-
devDepsInRoot.forEach((devDep) => delete fromContent[name][devDep]);
39+
// Use same versions of devDependencies across all workspaces.
40+
// After moving to yarn modern, we'll use constraints feature to enforce
41+
// consistency in dependency versions https://yarnpkg.com/features/constraints
42+
const devDepToVersionHash = {
43+
"@tsconfig/recommended": "1.0.1",
44+
concurrently: "7.0.0",
45+
"downlevel-dts": "0.7.0",
46+
rimraf: "3.0.2",
47+
typedoc: "0.19.2",
48+
typescript: "~4.3.5",
49+
};
50+
fromContent[name] = Object.keys(fromContent[name])
51+
.filter((dep) => Object.keys(devDepToVersionHash).includes(dep))
52+
.reduce((acc, dep) => ({ ...acc, [dep]: devDepToVersionHash[dep] }), fromContent[name]);
4953
}
5054
merged[name] = mergeManifest(fromContent[name], toContent[name]);
5155
if (name === "scripts" || name === "devDependencies") {

0 commit comments

Comments
 (0)