Skip to content

Commit 1308721

Browse files
AllanZhengYPAllanZhengYP
authored
fix(clients): lowercase all header names in serializer (#1892)
The HTTP request class doesn't have any implementations to insure case-insensitivity of the http headers. So we need to be mindful when populating these headers. Otherwise, the reqeust signature will be messed up. This change will ensure the protocol-specific default headers like content-type will be overriden by the serialized header if exists. For other headers added through middleware stack either by customization or users, it wouldn't affect signing or sending as long as the request doesn't contain same header names in different casing. All the internal headers will be consistent. But users should be careful when they are adding their own headers. We don't add middleware to lowercase all headers to prevent alternating the users' customizations. Ref: #1800
1 parent 7a3e8f4 commit 1308721

File tree

139 files changed

+4534
-4519
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

139 files changed

+4534
-4519
lines changed

‎clients/client-acm-pca/protocols/Aws_json1_1.ts

+23-23
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ export const serializeAws_json1_1CreateCertificateAuthorityCommand = async (
141141
): Promise<__HttpRequest> => {
142142
const headers: __HeaderBag = {
143143
"content-type": "application/x-amz-json-1.1",
144-
"X-Amz-Target": "ACMPrivateCA.CreateCertificateAuthority",
144+
"x-amz-target": "ACMPrivateCA.CreateCertificateAuthority",
145145
};
146146
let body: any;
147147
body = JSON.stringify(serializeAws_json1_1CreateCertificateAuthorityRequest(input, context));
@@ -154,7 +154,7 @@ export const serializeAws_json1_1CreateCertificateAuthorityAuditReportCommand =
154154
): Promise<__HttpRequest> => {
155155
const headers: __HeaderBag = {
156156
"content-type": "application/x-amz-json-1.1",
157-
"X-Amz-Target": "ACMPrivateCA.CreateCertificateAuthorityAuditReport",
157+
"x-amz-target": "ACMPrivateCA.CreateCertificateAuthorityAuditReport",
158158
};
159159
let body: any;
160160
body = JSON.stringify(serializeAws_json1_1CreateCertificateAuthorityAuditReportRequest(input, context));
@@ -167,7 +167,7 @@ export const serializeAws_json1_1CreatePermissionCommand = async (
167167
): Promise<__HttpRequest> => {
168168
const headers: __HeaderBag = {
169169
"content-type": "application/x-amz-json-1.1",
170-
"X-Amz-Target": "ACMPrivateCA.CreatePermission",
170+
"x-amz-target": "ACMPrivateCA.CreatePermission",
171171
};
172172
let body: any;
173173
body = JSON.stringify(serializeAws_json1_1CreatePermissionRequest(input, context));
@@ -180,7 +180,7 @@ export const serializeAws_json1_1DeleteCertificateAuthorityCommand = async (
180180
): Promise<__HttpRequest> => {
181181
const headers: __HeaderBag = {
182182
"content-type": "application/x-amz-json-1.1",
183-
"X-Amz-Target": "ACMPrivateCA.DeleteCertificateAuthority",
183+
"x-amz-target": "ACMPrivateCA.DeleteCertificateAuthority",
184184
};
185185
let body: any;
186186
body = JSON.stringify(serializeAws_json1_1DeleteCertificateAuthorityRequest(input, context));
@@ -193,7 +193,7 @@ export const serializeAws_json1_1DeletePermissionCommand = async (
193193
): Promise<__HttpRequest> => {
194194
const headers: __HeaderBag = {
195195
"content-type": "application/x-amz-json-1.1",
196-
"X-Amz-Target": "ACMPrivateCA.DeletePermission",
196+
"x-amz-target": "ACMPrivateCA.DeletePermission",
197197
};
198198
let body: any;
199199
body = JSON.stringify(serializeAws_json1_1DeletePermissionRequest(input, context));
@@ -206,7 +206,7 @@ export const serializeAws_json1_1DeletePolicyCommand = async (
206206
): Promise<__HttpRequest> => {
207207
const headers: __HeaderBag = {
208208
"content-type": "application/x-amz-json-1.1",
209-
"X-Amz-Target": "ACMPrivateCA.DeletePolicy",
209+
"x-amz-target": "ACMPrivateCA.DeletePolicy",
210210
};
211211
let body: any;
212212
body = JSON.stringify(serializeAws_json1_1DeletePolicyRequest(input, context));
@@ -219,7 +219,7 @@ export const serializeAws_json1_1DescribeCertificateAuthorityCommand = async (
219219
): Promise<__HttpRequest> => {
220220
const headers: __HeaderBag = {
221221
"content-type": "application/x-amz-json-1.1",
222-
"X-Amz-Target": "ACMPrivateCA.DescribeCertificateAuthority",
222+
"x-amz-target": "ACMPrivateCA.DescribeCertificateAuthority",
223223
};
224224
let body: any;
225225
body = JSON.stringify(serializeAws_json1_1DescribeCertificateAuthorityRequest(input, context));
@@ -232,7 +232,7 @@ export const serializeAws_json1_1DescribeCertificateAuthorityAuditReportCommand
232232
): Promise<__HttpRequest> => {
233233
const headers: __HeaderBag = {
234234
"content-type": "application/x-amz-json-1.1",
235-
"X-Amz-Target": "ACMPrivateCA.DescribeCertificateAuthorityAuditReport",
235+
"x-amz-target": "ACMPrivateCA.DescribeCertificateAuthorityAuditReport",
236236
};
237237
let body: any;
238238
body = JSON.stringify(serializeAws_json1_1DescribeCertificateAuthorityAuditReportRequest(input, context));
@@ -245,7 +245,7 @@ export const serializeAws_json1_1GetCertificateCommand = async (
245245
): Promise<__HttpRequest> => {
246246
const headers: __HeaderBag = {
247247
"content-type": "application/x-amz-json-1.1",
248-
"X-Amz-Target": "ACMPrivateCA.GetCertificate",
248+
"x-amz-target": "ACMPrivateCA.GetCertificate",
249249
};
250250
let body: any;
251251
body = JSON.stringify(serializeAws_json1_1GetCertificateRequest(input, context));
@@ -258,7 +258,7 @@ export const serializeAws_json1_1GetCertificateAuthorityCertificateCommand = asy
258258
): Promise<__HttpRequest> => {
259259
const headers: __HeaderBag = {
260260
"content-type": "application/x-amz-json-1.1",
261-
"X-Amz-Target": "ACMPrivateCA.GetCertificateAuthorityCertificate",
261+
"x-amz-target": "ACMPrivateCA.GetCertificateAuthorityCertificate",
262262
};
263263
let body: any;
264264
body = JSON.stringify(serializeAws_json1_1GetCertificateAuthorityCertificateRequest(input, context));
@@ -271,7 +271,7 @@ export const serializeAws_json1_1GetCertificateAuthorityCsrCommand = async (
271271
): Promise<__HttpRequest> => {
272272
const headers: __HeaderBag = {
273273
"content-type": "application/x-amz-json-1.1",
274-
"X-Amz-Target": "ACMPrivateCA.GetCertificateAuthorityCsr",
274+
"x-amz-target": "ACMPrivateCA.GetCertificateAuthorityCsr",
275275
};
276276
let body: any;
277277
body = JSON.stringify(serializeAws_json1_1GetCertificateAuthorityCsrRequest(input, context));
@@ -284,7 +284,7 @@ export const serializeAws_json1_1GetPolicyCommand = async (
284284
): Promise<__HttpRequest> => {
285285
const headers: __HeaderBag = {
286286
"content-type": "application/x-amz-json-1.1",
287-
"X-Amz-Target": "ACMPrivateCA.GetPolicy",
287+
"x-amz-target": "ACMPrivateCA.GetPolicy",
288288
};
289289
let body: any;
290290
body = JSON.stringify(serializeAws_json1_1GetPolicyRequest(input, context));
@@ -297,7 +297,7 @@ export const serializeAws_json1_1ImportCertificateAuthorityCertificateCommand =
297297
): Promise<__HttpRequest> => {
298298
const headers: __HeaderBag = {
299299
"content-type": "application/x-amz-json-1.1",
300-
"X-Amz-Target": "ACMPrivateCA.ImportCertificateAuthorityCertificate",
300+
"x-amz-target": "ACMPrivateCA.ImportCertificateAuthorityCertificate",
301301
};
302302
let body: any;
303303
body = JSON.stringify(serializeAws_json1_1ImportCertificateAuthorityCertificateRequest(input, context));
@@ -310,7 +310,7 @@ export const serializeAws_json1_1IssueCertificateCommand = async (
310310
): Promise<__HttpRequest> => {
311311
const headers: __HeaderBag = {
312312
"content-type": "application/x-amz-json-1.1",
313-
"X-Amz-Target": "ACMPrivateCA.IssueCertificate",
313+
"x-amz-target": "ACMPrivateCA.IssueCertificate",
314314
};
315315
let body: any;
316316
body = JSON.stringify(serializeAws_json1_1IssueCertificateRequest(input, context));
@@ -323,7 +323,7 @@ export const serializeAws_json1_1ListCertificateAuthoritiesCommand = async (
323323
): Promise<__HttpRequest> => {
324324
const headers: __HeaderBag = {
325325
"content-type": "application/x-amz-json-1.1",
326-
"X-Amz-Target": "ACMPrivateCA.ListCertificateAuthorities",
326+
"x-amz-target": "ACMPrivateCA.ListCertificateAuthorities",
327327
};
328328
let body: any;
329329
body = JSON.stringify(serializeAws_json1_1ListCertificateAuthoritiesRequest(input, context));
@@ -336,7 +336,7 @@ export const serializeAws_json1_1ListPermissionsCommand = async (
336336
): Promise<__HttpRequest> => {
337337
const headers: __HeaderBag = {
338338
"content-type": "application/x-amz-json-1.1",
339-
"X-Amz-Target": "ACMPrivateCA.ListPermissions",
339+
"x-amz-target": "ACMPrivateCA.ListPermissions",
340340
};
341341
let body: any;
342342
body = JSON.stringify(serializeAws_json1_1ListPermissionsRequest(input, context));
@@ -349,7 +349,7 @@ export const serializeAws_json1_1ListTagsCommand = async (
349349
): Promise<__HttpRequest> => {
350350
const headers: __HeaderBag = {
351351
"content-type": "application/x-amz-json-1.1",
352-
"X-Amz-Target": "ACMPrivateCA.ListTags",
352+
"x-amz-target": "ACMPrivateCA.ListTags",
353353
};
354354
let body: any;
355355
body = JSON.stringify(serializeAws_json1_1ListTagsRequest(input, context));
@@ -362,7 +362,7 @@ export const serializeAws_json1_1PutPolicyCommand = async (
362362
): Promise<__HttpRequest> => {
363363
const headers: __HeaderBag = {
364364
"content-type": "application/x-amz-json-1.1",
365-
"X-Amz-Target": "ACMPrivateCA.PutPolicy",
365+
"x-amz-target": "ACMPrivateCA.PutPolicy",
366366
};
367367
let body: any;
368368
body = JSON.stringify(serializeAws_json1_1PutPolicyRequest(input, context));
@@ -375,7 +375,7 @@ export const serializeAws_json1_1RestoreCertificateAuthorityCommand = async (
375375
): Promise<__HttpRequest> => {
376376
const headers: __HeaderBag = {
377377
"content-type": "application/x-amz-json-1.1",
378-
"X-Amz-Target": "ACMPrivateCA.RestoreCertificateAuthority",
378+
"x-amz-target": "ACMPrivateCA.RestoreCertificateAuthority",
379379
};
380380
let body: any;
381381
body = JSON.stringify(serializeAws_json1_1RestoreCertificateAuthorityRequest(input, context));
@@ -388,7 +388,7 @@ export const serializeAws_json1_1RevokeCertificateCommand = async (
388388
): Promise<__HttpRequest> => {
389389
const headers: __HeaderBag = {
390390
"content-type": "application/x-amz-json-1.1",
391-
"X-Amz-Target": "ACMPrivateCA.RevokeCertificate",
391+
"x-amz-target": "ACMPrivateCA.RevokeCertificate",
392392
};
393393
let body: any;
394394
body = JSON.stringify(serializeAws_json1_1RevokeCertificateRequest(input, context));
@@ -401,7 +401,7 @@ export const serializeAws_json1_1TagCertificateAuthorityCommand = async (
401401
): Promise<__HttpRequest> => {
402402
const headers: __HeaderBag = {
403403
"content-type": "application/x-amz-json-1.1",
404-
"X-Amz-Target": "ACMPrivateCA.TagCertificateAuthority",
404+
"x-amz-target": "ACMPrivateCA.TagCertificateAuthority",
405405
};
406406
let body: any;
407407
body = JSON.stringify(serializeAws_json1_1TagCertificateAuthorityRequest(input, context));
@@ -414,7 +414,7 @@ export const serializeAws_json1_1UntagCertificateAuthorityCommand = async (
414414
): Promise<__HttpRequest> => {
415415
const headers: __HeaderBag = {
416416
"content-type": "application/x-amz-json-1.1",
417-
"X-Amz-Target": "ACMPrivateCA.UntagCertificateAuthority",
417+
"x-amz-target": "ACMPrivateCA.UntagCertificateAuthority",
418418
};
419419
let body: any;
420420
body = JSON.stringify(serializeAws_json1_1UntagCertificateAuthorityRequest(input, context));
@@ -427,7 +427,7 @@ export const serializeAws_json1_1UpdateCertificateAuthorityCommand = async (
427427
): Promise<__HttpRequest> => {
428428
const headers: __HeaderBag = {
429429
"content-type": "application/x-amz-json-1.1",
430-
"X-Amz-Target": "ACMPrivateCA.UpdateCertificateAuthority",
430+
"x-amz-target": "ACMPrivateCA.UpdateCertificateAuthority",
431431
};
432432
let body: any;
433433
body = JSON.stringify(serializeAws_json1_1UpdateCertificateAuthorityRequest(input, context));

‎clients/client-acm/protocols/Aws_json1_1.ts

+13-13
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export const serializeAws_json1_1AddTagsToCertificateCommand = async (
9494
): Promise<__HttpRequest> => {
9595
const headers: __HeaderBag = {
9696
"content-type": "application/x-amz-json-1.1",
97-
"X-Amz-Target": "CertificateManager.AddTagsToCertificate",
97+
"x-amz-target": "CertificateManager.AddTagsToCertificate",
9898
};
9999
let body: any;
100100
body = JSON.stringify(serializeAws_json1_1AddTagsToCertificateRequest(input, context));
@@ -107,7 +107,7 @@ export const serializeAws_json1_1DeleteCertificateCommand = async (
107107
): Promise<__HttpRequest> => {
108108
const headers: __HeaderBag = {
109109
"content-type": "application/x-amz-json-1.1",
110-
"X-Amz-Target": "CertificateManager.DeleteCertificate",
110+
"x-amz-target": "CertificateManager.DeleteCertificate",
111111
};
112112
let body: any;
113113
body = JSON.stringify(serializeAws_json1_1DeleteCertificateRequest(input, context));
@@ -120,7 +120,7 @@ export const serializeAws_json1_1DescribeCertificateCommand = async (
120120
): Promise<__HttpRequest> => {
121121
const headers: __HeaderBag = {
122122
"content-type": "application/x-amz-json-1.1",
123-
"X-Amz-Target": "CertificateManager.DescribeCertificate",
123+
"x-amz-target": "CertificateManager.DescribeCertificate",
124124
};
125125
let body: any;
126126
body = JSON.stringify(serializeAws_json1_1DescribeCertificateRequest(input, context));
@@ -133,7 +133,7 @@ export const serializeAws_json1_1ExportCertificateCommand = async (
133133
): Promise<__HttpRequest> => {
134134
const headers: __HeaderBag = {
135135
"content-type": "application/x-amz-json-1.1",
136-
"X-Amz-Target": "CertificateManager.ExportCertificate",
136+
"x-amz-target": "CertificateManager.ExportCertificate",
137137
};
138138
let body: any;
139139
body = JSON.stringify(serializeAws_json1_1ExportCertificateRequest(input, context));
@@ -146,7 +146,7 @@ export const serializeAws_json1_1GetCertificateCommand = async (
146146
): Promise<__HttpRequest> => {
147147
const headers: __HeaderBag = {
148148
"content-type": "application/x-amz-json-1.1",
149-
"X-Amz-Target": "CertificateManager.GetCertificate",
149+
"x-amz-target": "CertificateManager.GetCertificate",
150150
};
151151
let body: any;
152152
body = JSON.stringify(serializeAws_json1_1GetCertificateRequest(input, context));
@@ -159,7 +159,7 @@ export const serializeAws_json1_1ImportCertificateCommand = async (
159159
): Promise<__HttpRequest> => {
160160
const headers: __HeaderBag = {
161161
"content-type": "application/x-amz-json-1.1",
162-
"X-Amz-Target": "CertificateManager.ImportCertificate",
162+
"x-amz-target": "CertificateManager.ImportCertificate",
163163
};
164164
let body: any;
165165
body = JSON.stringify(serializeAws_json1_1ImportCertificateRequest(input, context));
@@ -172,7 +172,7 @@ export const serializeAws_json1_1ListCertificatesCommand = async (
172172
): Promise<__HttpRequest> => {
173173
const headers: __HeaderBag = {
174174
"content-type": "application/x-amz-json-1.1",
175-
"X-Amz-Target": "CertificateManager.ListCertificates",
175+
"x-amz-target": "CertificateManager.ListCertificates",
176176
};
177177
let body: any;
178178
body = JSON.stringify(serializeAws_json1_1ListCertificatesRequest(input, context));
@@ -185,7 +185,7 @@ export const serializeAws_json1_1ListTagsForCertificateCommand = async (
185185
): Promise<__HttpRequest> => {
186186
const headers: __HeaderBag = {
187187
"content-type": "application/x-amz-json-1.1",
188-
"X-Amz-Target": "CertificateManager.ListTagsForCertificate",
188+
"x-amz-target": "CertificateManager.ListTagsForCertificate",
189189
};
190190
let body: any;
191191
body = JSON.stringify(serializeAws_json1_1ListTagsForCertificateRequest(input, context));
@@ -198,7 +198,7 @@ export const serializeAws_json1_1RemoveTagsFromCertificateCommand = async (
198198
): Promise<__HttpRequest> => {
199199
const headers: __HeaderBag = {
200200
"content-type": "application/x-amz-json-1.1",
201-
"X-Amz-Target": "CertificateManager.RemoveTagsFromCertificate",
201+
"x-amz-target": "CertificateManager.RemoveTagsFromCertificate",
202202
};
203203
let body: any;
204204
body = JSON.stringify(serializeAws_json1_1RemoveTagsFromCertificateRequest(input, context));
@@ -211,7 +211,7 @@ export const serializeAws_json1_1RenewCertificateCommand = async (
211211
): Promise<__HttpRequest> => {
212212
const headers: __HeaderBag = {
213213
"content-type": "application/x-amz-json-1.1",
214-
"X-Amz-Target": "CertificateManager.RenewCertificate",
214+
"x-amz-target": "CertificateManager.RenewCertificate",
215215
};
216216
let body: any;
217217
body = JSON.stringify(serializeAws_json1_1RenewCertificateRequest(input, context));
@@ -224,7 +224,7 @@ export const serializeAws_json1_1RequestCertificateCommand = async (
224224
): Promise<__HttpRequest> => {
225225
const headers: __HeaderBag = {
226226
"content-type": "application/x-amz-json-1.1",
227-
"X-Amz-Target": "CertificateManager.RequestCertificate",
227+
"x-amz-target": "CertificateManager.RequestCertificate",
228228
};
229229
let body: any;
230230
body = JSON.stringify(serializeAws_json1_1RequestCertificateRequest(input, context));
@@ -237,7 +237,7 @@ export const serializeAws_json1_1ResendValidationEmailCommand = async (
237237
): Promise<__HttpRequest> => {
238238
const headers: __HeaderBag = {
239239
"content-type": "application/x-amz-json-1.1",
240-
"X-Amz-Target": "CertificateManager.ResendValidationEmail",
240+
"x-amz-target": "CertificateManager.ResendValidationEmail",
241241
};
242242
let body: any;
243243
body = JSON.stringify(serializeAws_json1_1ResendValidationEmailRequest(input, context));
@@ -250,7 +250,7 @@ export const serializeAws_json1_1UpdateCertificateOptionsCommand = async (
250250
): Promise<__HttpRequest> => {
251251
const headers: __HeaderBag = {
252252
"content-type": "application/x-amz-json-1.1",
253-
"X-Amz-Target": "CertificateManager.UpdateCertificateOptions",
253+
"x-amz-target": "CertificateManager.UpdateCertificateOptions",
254254
};
255255
let body: any;
256256
body = JSON.stringify(serializeAws_json1_1UpdateCertificateOptionsRequest(input, context));

0 commit comments

Comments
 (0)