Skip to content

Commit 117e9ca

Browse files
authored
chore: remove redundant return from xml serialize (#1182)
1 parent 5a92d6b commit 117e9ca

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

Diff for: codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/XmlShapeSerVisitor.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ protected void serializeCollection(GenerationContext context, CollectionShape sh
7878
writer.openBlock("return node.reduce((acc: __XmlNode, workingNode: any) => {", "}", () -> {
7979
// Add @xmlNamespace value of the target member.
8080
AwsProtocolUtils.writeXmlNamespace(context, memberShape, "workingNode");
81-
writer.write("acc.addChildNode(workingNode);");
82-
writer.write("return acc;");
81+
writer.write("return acc.addChildNode(workingNode);");
8382
});
8483
writer.write(", new __XmlNode($S));", locationName);
8584
} else {
@@ -134,8 +133,7 @@ protected void serializeMap(GenerationContext context, MapShape shape) {
134133
writer.openBlock("node.reduce((acc: __XmlNode, workingNode: any) => {", "}", () -> {
135134
// Add @xmlNamespace value of the value member.
136135
AwsProtocolUtils.writeXmlNamespace(context, valueMember, "workingNode");
137-
writer.write("acc.addChildNode(workingNode);");
138-
writer.write("return acc;");
136+
writer.write("return acc.addChildNode(workingNode);");
139137
});
140138
writer.write(", new __XmlNode($S));", valueName);
141139
});

Diff for: protocol_tests/aws-restxml/protocols/Aws_restXml.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -4440,8 +4440,7 @@ const serializeAws_restXmlNestedStringList = (
44404440
return input.map(entry => {
44414441
const node = serializeAws_restXmlStringList(entry, context);
44424442
return node.reduce((acc: __XmlNode, workingNode: any) => {
4443-
acc.addChildNode(workingNode);
4444-
return acc;
4443+
return acc.addChildNode(workingNode);
44454444
}, new __XmlNode("member"));
44464445
});
44474446
};

0 commit comments

Comments
 (0)