Skip to content

Commit 06383bb

Browse files
Chase Coalwelltrivikr
Chase Coalwell
authored andcommitted
Fix plugin predicates (#569)
1 parent 8d7c337 commit 06383bb

File tree

1 file changed

+14
-14
lines changed
  • codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen

1 file changed

+14
-14
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AddBuiltinPlugins.java

+14-14
Original file line numberDiff line numberDiff line change
@@ -103,44 +103,44 @@ public List<RuntimeClientPlugin> getClientPlugins() {
103103
.build(),
104104
RuntimeClientPlugin.builder()
105105
.withConventions(AwsDependency.SSEC_MIDDLEWARE.dependency, "Ssec", HAS_MIDDLEWARE)
106-
.servicePredicate((m, s) -> testServiceId(s, "S3"))
107-
.operationPredicate((m, s, o) -> testInputContainsMember(m, o, SSEC_OPERATIONS))
106+
.operationPredicate((m, s, o) -> testInputContainsMember(m, o, SSEC_OPERATIONS)
107+
&& testServiceId(s, "S3"))
108108
.build(),
109109
RuntimeClientPlugin.builder()
110110
.withConventions(AwsDependency.LOCATION_CONSTRAINT.dependency, "LocationConstraint",
111111
HAS_MIDDLEWARE)
112-
.servicePredicate((m, s) -> testServiceId(s, "S3"))
113-
.operationPredicate((m, s, o) -> o.getId().getName().equals("CreateBucket"))
112+
.operationPredicate((m, s, o) -> o.getId().getName().equals("CreateBucket")
113+
&& testServiceId(s, "S3"))
114114
.build(),
115115
RuntimeClientPlugin.builder()
116116
.withConventions(AwsDependency.MACHINELEARNING_MIDDLEWARE.dependency, "PredictEndpoint",
117117
HAS_MIDDLEWARE)
118-
.servicePredicate((m, s) -> testServiceId(s, "Machine Learning"))
119-
.operationPredicate((m, s, o) -> o.getId().getName().equals("Predict"))
118+
.operationPredicate((m, s, o) -> o.getId().getName().equals("Predict")
119+
&& testServiceId(s, "Machine Learning"))
120120
.build(),
121121
RuntimeClientPlugin.builder()
122122
.withConventions(AwsDependency.BUCKET_ENDPOINT_MIDDLEWARE.dependency, "BucketEndpoint",
123123
HAS_MIDDLEWARE)
124-
.servicePredicate((m, s) -> testServiceId(s, "S3"))
125-
.operationPredicate((m, s, o) -> !NON_BUCKET_ENDPOINT_OPERATIONS.contains(o.getId().getName()))
124+
.operationPredicate((m, s, o) -> !NON_BUCKET_ENDPOINT_OPERATIONS.contains(o.getId().getName())
125+
&& testServiceId(s, "S3"))
126126
.build(),
127127
RuntimeClientPlugin.builder()
128128
.withConventions(AwsDependency.BODY_CHECKSUM.dependency, "ApplyMd5BodyChecksum",
129129
HAS_MIDDLEWARE)
130-
.servicePredicate((m, s) -> testServiceId(s, "S3"))
131-
.operationPredicate((m, s, o) -> S3_MD5_OPERATIONS.contains(o.getId().getName()))
130+
.operationPredicate((m, s, o) -> S3_MD5_OPERATIONS.contains(o.getId().getName())
131+
&& testServiceId(s, "S3"))
132132
.build(),
133133
RuntimeClientPlugin.builder()
134134
.withConventions(AwsDependency.ROUTE53_MIDDLEWARE.dependency,
135135
"ChangeResourceRecordSets", HAS_MIDDLEWARE)
136-
.servicePredicate((m, s) -> testServiceId(s, "Route 53"))
137-
.operationPredicate((m, s, o) -> o.getId().getName().equals("ChangeResourceRecordSets"))
136+
.operationPredicate((m, s, o) -> o.getId().getName().equals("ChangeResourceRecordSets")
137+
&& testServiceId(s, "Route 53"))
138138
.build(),
139139
RuntimeClientPlugin.builder()
140140
.withConventions(AwsDependency.ROUTE53_MIDDLEWARE.dependency, "IdNormalizer",
141141
HAS_MIDDLEWARE)
142-
.servicePredicate((m, s) -> testServiceId(s, "Route 53"))
143-
.operationPredicate((m, s, o) -> testInputContainsMember(m, o, ROUTE_53_ID_MEMBERS))
142+
.operationPredicate((m, s, o) -> testInputContainsMember(m, o, ROUTE_53_ID_MEMBERS)
143+
&& testServiceId(s, "Route 53"))
144144
.build(),
145145
RuntimeClientPlugin.builder()
146146
.withConventions(AwsDependency.MIDDLEWARE_HOST_HEADER.dependency, "HostHeader")

0 commit comments

Comments
 (0)