Skip to content

Commit 010f9d6

Browse files
authored
chore(codegen): enable RestJSON tests disabled during smithy 1.14.x bump (#3062)
* chore(codegen): enable RestJSON tests disabled during smithy 1.14.x bump * chore(protocol_tests): enable RestJSON tests disabled during smithy 1.14.x bump
1 parent 27fd7b7 commit 010f9d6

File tree

2 files changed

+2
-11
lines changed

2 files changed

+2
-11
lines changed

codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -355,15 +355,6 @@ private static boolean filterProtocolTests(
355355
HttpMessageTestCase testCase,
356356
TypeScriptSettings settings
357357
) {
358-
// TODO: Remove when server protocol tests are fixed in
359-
// https://github.com/aws/aws-sdk-js-v3/issues/3058
360-
// TODO: Move to filter specific to server protocol tests if added in
361-
// https://github.com/awslabs/smithy-typescript/issues/470
362-
if (testCase.getId().equals("RestJsonTestPayloadStructure")
363-
|| testCase.getId().equals("RestJsonHttpWithHeadersButNoPayload")) {
364-
return true;
365-
}
366-
367358
// TODO: Remove when requestCompression has been implemented.
368359
if (testCase.getId().startsWith("SDKAppliedContentEncoding_")
369360
|| testCase.getId().startsWith("SDKAppendsGzipAndIgnoresHttpProvidedEncoding_")

private/aws-protocoltests-restjson/test/functional/restjson1.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8915,7 +8915,7 @@ it("RestJsonHttpWithEmptyStructurePayload:Request", async () => {
89158915
/**
89168916
* Serializes a payload targeting a structure
89178917
*/
8918-
it.skip("RestJsonTestPayloadStructure:Request", async () => {
8918+
it("RestJsonTestPayloadStructure:Request", async () => {
89198919
const client = new RestJsonProtocolClient({
89208920
...clientParams,
89218921
requestHandler: new RequestSerializationTestHandler(),
@@ -8955,7 +8955,7 @@ it.skip("RestJsonTestPayloadStructure:Request", async () => {
89558955
/**
89568956
* Serializes an request with header members but no payload
89578957
*/
8958-
it.skip("RestJsonHttpWithHeadersButNoPayload:Request", async () => {
8958+
it("RestJsonHttpWithHeadersButNoPayload:Request", async () => {
89598959
const client = new RestJsonProtocolClient({
89608960
...clientParams,
89618961
requestHandler: new RequestSerializationTestHandler(),

0 commit comments

Comments
 (0)