From 1ba90268838f7c760c315205c954c633b6c2b4d1 Mon Sep 17 00:00:00 2001 From: David Ho Date: Tue, 30 Aug 2022 16:16:54 -0700 Subject: [PATCH 1/2] Clarify error message in Runnable Request for connection acquisition timeouts Replacing "pool lease timeout" with "connection acquisition timeout" --- .../awssdk/http/nio/netty/internal/utils/NettyUtils.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java index 4f417903b64f..2dce3ce51316 100644 --- a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java +++ b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java @@ -115,7 +115,8 @@ private static String getMessageForTooManyAcquireOperationsError() { return "Maximum pending connection acquisitions exceeded. The request rate is too high for the client to keep up.\n" + "Consider taking any of the following actions to mitigate the issue: increase max connections, " - + "increase max pending acquire count, decrease pool lease timeout, or slowing the request rate.\n" + + "increase max pending acquire count, decrease connection acquisition timeout, or " + + "slowing the request rate.\n" + "Increasing the max connections can increase client throughput (unless the network interface is already " + "fully utilized), but can eventually start to hit operation system limitations on the number of file " From 65cf5f9bbea28b3f00bb2fccb6d73eb67112319e Mon Sep 17 00:00:00 2001 From: David Ho Date: Wed, 31 Aug 2022 12:23:30 -0700 Subject: [PATCH 2/2] Update error message in Runnable Request Changing "slowing" to "slow" --- .../amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java index 2dce3ce51316..5cacc5d67451 100644 --- a/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java +++ b/http-clients/netty-nio-client/src/main/java/software/amazon/awssdk/http/nio/netty/internal/utils/NettyUtils.java @@ -116,7 +116,7 @@ private static String getMessageForTooManyAcquireOperationsError() { + "Consider taking any of the following actions to mitigate the issue: increase max connections, " + "increase max pending acquire count, decrease connection acquisition timeout, or " - + "slowing the request rate.\n" + + "slow the request rate.\n" + "Increasing the max connections can increase client throughput (unless the network interface is already " + "fully utilized), but can eventually start to hit operation system limitations on the number of file "