Skip to content

Please make EC2MetadataUtils non-internal #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slukes opened this issue Dec 21, 2018 · 3 comments
Closed

Please make EC2MetadataUtils non-internal #972

slukes opened this issue Dec 21, 2018 · 3 comments
Labels
feature-request A feature should be added or improved.

Comments

@slukes
Copy link

slukes commented Dec 21, 2018

EC2MetadataUtils is currently an internal API, theoretically means each applications developer needs to re-invent the wheel in order to obtain, for example, the instance id of the ec2 their application is running on.

Expected Behavior

Please remove this class from the internal package.
Ideally, please make the api non-static to allow for easier testing of application code.
@zoewangg
Copy link
Contributor

Related to #61

We have plans to refactor Ec2MetadataUtils and make it public, but it may not happen soon. PRs are welcome!

@slukes
Copy link
Author

slukes commented Dec 28, 2018

Hello, I'm happy to contribute this.

Please could you provide any guidance as to what you have in mind an obvious lift / shift?

@justnance justnance added feature-request A feature should be added or improved. and removed Feature Request labels Apr 19, 2019
@millems
Copy link
Contributor

millems commented Jul 8, 2019

Resolving to track in #61

@millems millems closed this as completed Jul 8, 2019
@PyvesB PyvesB mentioned this issue Sep 12, 2019
Closed
@rtyley rtyley mentioned this issue Oct 31, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@slukes @millems @zoewangg @justnance