Skip to content

Async support for WebIdentityTokenCredentialsProvider #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 tasks
tms0 opened this issue Nov 7, 2023 · 3 comments
Open
2 tasks

Async support for WebIdentityTokenCredentialsProvider #4672

tms0 opened this issue Nov 7, 2023 · 3 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@tms0
Copy link

tms0 commented Nov 7, 2023

Describe the feature

Add support for WebIdentityTokenCredentialsProvider to use an async client

Use Case

Same use case than in this previous issue : #1881

If I understand correctly, the new STSWebIdentityTokenCredentialsProvider didn't add the ability to use an async client. So we still need to add a sync http client on the classpath to use the WebIdentityTokenCredentialsProvider.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.21.16

JDK version used

openjdk version "17.0.1" 2021-10-19

Operating System and version

macOS Monterey

@tms0 tms0 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 7, 2023
@debora-ito debora-ito self-assigned this Nov 7, 2023
@debora-ito
Copy link
Member

@tms0 the STS client is only used to make the assumeRoleWithWebIdentity call. Is there any particular reason you need to use the async client? Do you explicitly remove the sync clients from the classpath?

@debora-ito debora-ito added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 7, 2023
@tms0
Copy link
Author

tms0 commented Nov 7, 2023

Hi @debora-ito,

I use the Quarkus extension (https://github.com/quarkiverse/quarkus-amazon-services/tree/main) which explicitly exclude all the http clients to let us include only those needed.

But currently, I have to include both an async client (because I want to do non-blocking programming) and a sync client to use the WebIdentityTokenCredentialsProvider.

As a good practice, and particulary in a Quarkus / GraalVM world, I want to include as few dependencies as possible.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Nov 7, 2023
@debora-ito debora-ito added the needs-review This issue or PR needs review from the team. label Nov 7, 2023
@debora-ito
Copy link
Member

Thank you for the additional details. Acknowledged as a feature request.

Community note: please vote by adding a 👍 reaction to the original issue to help us with prioritization.

@debora-ito debora-ito removed the needs-review This issue or PR needs review from the team. label Nov 11, 2023
@debora-ito debora-ito removed their assignment Nov 11, 2023
@debora-ito debora-ito added the p2 This is a standard priority issue label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants