Skip to content

Documentation on thread safetiness of DynamoDbIndex #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arakiy117 opened this issue Feb 18, 2022 · 2 comments · Fixed by #3136
Closed

Documentation on thread safetiness of DynamoDbIndex #3044

arakiy117 opened this issue Feb 18, 2022 · 2 comments · Fixed by #3136
Labels
documentation This is a problem with documentation. dynamodb-enhanced

Comments

@arakiy117
Copy link

Describe the issue

I have found similar inquiry for SdkClient thread safety as well as the statement (attached below for reference) on service clients' thread safety, but I am unable to find any documentation on thread safety for some of the components, such as DynamoDbIndex.

My inquiry are

  1. Is DynamoDbIndex thread safe?
  2. If so, could we have this added in official documentation and/or via annotations similar to the service clients?

Statement on service client thread safety from the developer guide:

Service clients in the SDK are thread-safe. For best performance, treat them as long-lived
objects. Each client has its own connection pool resource that is released when the client is
garbage collected.

Links

https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/aws-sdk-java-dg-v2.pdf

https://github.com/aws/aws-sdk-java-v2/blob/master/services-custom/dynamodb-enhanced/src/main/java/software/amazon/awssdk/enhanced/dynamodb/DynamoDbIndex.java

@arakiy117 arakiy117 added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Feb 18, 2022
@debora-ito
Copy link
Member

@arakiy117 thank you for the suggestion, we'll look into it.

I'm not sure if the DynamoDB Enhanced Client classes are thread safe, I'll get back with this info.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. dynamodb-enhanced
Projects
None yet
2 participants