Skip to content

Disable Apache normalization #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Disable Apache normalization #1224

merged 2 commits into from
Jul 2, 2019

Conversation

varunnvs92
Copy link
Contributor

@varunnvs92 varunnvs92 commented Apr 23, 2019

  • Disable Apache normalization to handle breaking change introduced in v4.5.7
  • Update httpcomponents.httpclient.version to 4.5.9

See aws/aws-sdk-java#1919 for more details.

@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #1224 into master will decrease coverage by 11.12%.
The diff coverage is 87.5%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1224       +/-   ##
=============================================
- Coverage     70.14%   59.02%   -11.13%     
- Complexity      188     4632     +4444     
=============================================
  Files           776      747       -29     
  Lines         24122    23191      -931     
  Branches       1799     1737       -62     
=============================================
- Hits          16920    13688     -3232     
- Misses         6420     8808     +2388     
+ Partials        782      695       -87
Flag Coverage Δ Complexity Δ
#unittests ? ?
Impacted Files Coverage Δ Complexity Δ
...apache/internal/impl/ApacheHttpRequestFactory.java 71.42% <100%> (-18.82%) 13 <0> (+13)
...awssdk/http/apache/internal/utils/ApacheUtils.java 36.66% <85.71%> (+14.92%) 4 <1> (+4) ⬆️
...protocols/json/DefaultJsonContentTypeResolver.java 0% <0%> (-100%) 0% <0%> (ø)
...awssdk/protocols/json/AwsJsonProtocolMetadata.java 0% <0%> (-100%) 0% <0%> (ø)
...ftware/amazon/awssdk/core/traits/PayloadTrait.java 0% <0%> (-100%) 0% <0%> (ø)
...tware/amazon/awssdk/core/traits/LocationTrait.java 0% <0%> (-100%) 0% <0%> (ø)
...ventstream/EventStreamTaggedUnionPojoSupplier.java 0% <0%> (-100%) 0% <0%> (ø)
.../awssdk/protocols/json/AwsJsonProtocolFactory.java 0% <0%> (-100%) 0% <0%> (ø)
...e/amazon/awssdk/awscore/AwsExecutionAttribute.java 0% <0%> (-100%) 0% <0%> (ø)
...gions/providers/DefaultAwsRegionProviderChain.java 0% <0%> (-100%) 0% <0%> (ø)
... and 293 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c93f85d...2553e89. Read the comment docs.

@zoewangg
Copy link
Contributor

zoewangg commented Jul 1, 2019

Integ tests and stability tests passed.

@zoewangg zoewangg force-pushed the varunkn/ApacheTest branch from c8ded61 to 595db3e Compare July 2, 2019 21:42
@varunnvs92
Copy link
Contributor Author

Reviewed the changes pushed by @zoewangg . They lgtm.

@zoewangg zoewangg force-pushed the varunkn/ApacheTest branch from c4d6a95 to 66116a6 Compare July 2, 2019 22:54
@zoewangg zoewangg merged commit 7dadbe8 into master Jul 2, 2019
@zoewangg zoewangg deleted the varunkn/ApacheTest branch July 3, 2019 00:24
aws-sdk-java-automation added a commit that referenced this pull request Mar 15, 2021
…c24dda317

Pull request: release <- staging/a76a3b62-463a-4f98-9ff2-a3cc24dda317
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants