-
Notifications
You must be signed in to change notification settings - Fork 910
Adding client type and client name to user agent #1218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we review this format with the metrics team, and make sure we're not exceeding any length limits? |
Codecov Report
@@ Coverage Diff @@
## master #1218 +/- ##
============================================
- Coverage 59.18% 59.18% -0.01%
- Complexity 4659 4660 +1
============================================
Files 750 750
Lines 23267 23291 +24
Branches 1742 1744 +2
============================================
+ Hits 13771 13784 +13
- Misses 8800 8810 +10
- Partials 696 697 +1
Continue to review full report at Codecov.
|
Code LGTM. Per discussion today, waiting on updating the names. |
f3bea93
to
16ac145
Compare
Updated to io/[sync/async] and http/[Apache/Netty/UrlConnection] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1597595
to
335d8cf
Compare
…1e6171039 Pull request: release <- staging/b235279d-101a-4328-852c-bcf1e6171039
Adds the client type (sync/async/unknown) and client name (Apache/NettyNio/UrlConnection/Etc) to the user agent in the form of clientType/clientName (sync/Apache).
Motivation and Context
Allows us to track which clients are being used for a request.
Testing
Updated existing tests
Added interceptor to S3 tests to verify user agent on sync and async client
Types of changes
Checklist
mvn install
succeedsLicense